From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22276 invoked by alias); 20 Aug 2013 19:44:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22250 invoked by uid 89); 20 Aug 2013 19:44:58 -0000 X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=unavailable version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 20 Aug 2013 19:44:58 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7KJip0d016605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Aug 2013 15:44:52 -0400 Received: from localhost.localdomain (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7KJiits017867; Tue, 20 Aug 2013 15:44:46 -0400 Message-ID: <5213C72B.20600@redhat.com> Date: Tue, 20 Aug 2013 19:51:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Jonathan Wakely CC: Tom Tromey , gcc-patches@sourceware.org, libstdc++ Subject: Re: [patch] [python libstdc++ printers] Fix gdb/15195 References: <514ADF9B.1090407@redhat.com> <87mwtw4yy6.fsf@fleche.redhat.com> <51B6E3C5.3000209@redhat.com> <87sj0mglyg.fsf@fleche.redhat.com> <51D3D3C6.2030001@redhat.com> <51ED030C.8000605@redhat.com> <87d2q91hjh.fsf@fleche.redhat.com> <520DF73E.2090203__11644.8208028034$1376647004$gmane$org@redhat.com> <877gflmz8s.fsf@fleche.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg01145.txt.bz2 On 19/08/13 09:00, Jonathan Wakely wrote: > On 16 August 2013 16:28, Tom Tromey wrote: >>>>>>> "Phil" == Phil Muldoon writes: >> >> Phil> Anyway, I have regenerated the patch with the fixes requested. >> >> Thanks. >> >> Phil> 2013-08-16 Phil Muldoon >> >> Phil> PR gcc/53477 >> >> I think this should say PR libstdc++/53477 >> >> Other than this nit, it looks good to me. >> I can't remember if I can approve these, but I think not. > > I can though, so it's approved with the ChangeLog nit fixed. Committed with ChangeLog fix: 2013-08-20 Phil Muldoon PR libstdc++/53477 http://sourceware.org/bugzilla/show_bug.cgi?id=15195 * python/libstdcxx/v6/printers.py (Printer.__call__): If a value is a reference, fetch referenced value. (RxPrinter.invoke): Ditto. * testsuite/libstdc++-prettyprinters/cxx11.cc (main): Add -O0 flag. Add referenced value tests. Patch was as posted. Cheers, Phil