From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7222 invoked by alias); 23 Aug 2013 10:29:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7200 invoked by uid 89); 23 Aug 2013 10:29:42 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 10:29:41 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r7NATddR001693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Aug 2013 10:29:40 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7NATcNN004624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Aug 2013 10:29:38 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7NATcGn004615; Fri, 23 Aug 2013 10:29:38 GMT Received: from poldo4.casa (/79.52.195.215) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 23 Aug 2013 03:29:38 -0700 Message-ID: <5217398F.50202@oracle.com> Date: Fri, 23 Aug 2013 11:08:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Tim Shen CC: libstdc++ , gcc-patches Subject: Re: [Patch 2/2] Localization problem in regex References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg01343.txt.bz2 Hi, On 08/23/2013 11:17 AM, Tim Shen wrote: > 2013-08-23 Tim Shen > > * include/bits/regex.h: Fix callers. > * include/bits/regex_compiler.h: Store _Traits reference. > * include/bits/regex_executor.h: Add _Traits member for _DFSExecutor. > * include/bits/regex_executor.tcc: Likewise. > * testsuite/28_regex/algorithms/regex_match/extended/wstring_locale.cc: > New. Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*? To be really honest this kind of ChangeLog entry doesn't make much sense. Please get used to list the specific functions you are changing. It's important. Thanks, Paolo.