public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: Richard Biener <rguenther@suse.de>,
	       Bernd Schmidt <bernds@codesourcery.com>,
	gcc-patches@gcc.gnu.org,        jason@redhat.com
Subject: Re: [RFC] Fix for PR58201
Date: Sat, 07 Sep 2013 09:09:00 -0000	[thread overview]
Message-ID: <522AEB26.5060701@oracle.com> (raw)
In-Reply-To: <20130907082846.GC4841@kam.mff.cuni.cz>

Hi Honza,

and thanks for the analysis, now I understand the issue a little more.

On 09/07/2013 10:28 AM, Jan Hubicka wrote:
> So it is just an accident that the line info is output sanely (if line 
> 9 is sane, I don't exactly know)
I would say that in general it's definitely sane, because that is the 
instantiation point. And 10 is wrong, too late, it points to the closing 
bracket.

However, I notice that clang doesn't even try to output a message having 
to do with line 9: if I understand correctly, if that operator cannot be 
mangled, that happens unconditionally, isn't something that may succeed. 
Thus I wonder if, instead of outputting garbage line numbers we could at 
least suppress in such cases the whole "In instantiation of..." part of 
the diagnostic, it would be better than garbage. Do we have a mechanism 
for that?

Now I also understand that this should be a very uncommon error message, 
but, I'm wondering, is it possible that other errors, for other issues, 
are also affected? That is, other diagnostic happening very late and 
sensitive to the recent rework?

Paolo.

  reply	other threads:[~2013-09-07  9:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 16:04 Jan Hubicka
2013-09-04 16:12 ` Jakub Jelinek
2013-09-04 16:49 ` Bernd Schmidt
2013-09-04 17:09   ` Jan Hubicka
2013-09-04 17:26     ` Bernd Schmidt
2013-09-04 18:44     ` Richard Biener
2013-09-05 23:05       ` Jan Hubicka
2013-09-06 16:02         ` Paolo Carlini
2013-09-07  8:04           ` Jan Hubicka
2013-09-07  9:01             ` Jan Hubicka
2013-09-07  9:09               ` Paolo Carlini [this message]
2013-09-07  9:15                 ` Jan Hubicka
2013-09-07 11:22                 ` Jakub Jelinek
2013-09-07 21:00                   ` Paolo Carlini
2013-09-08  0:26                     ` Jan Hubicka
2013-09-08  0:34                       ` Jan Hubicka
2013-09-07 10:33               ` Paolo Carlini
2013-09-07 16:42                 ` Jason Merrill
2013-09-04 18:18   ` Jeff Law
2013-09-05  8:20     ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522AEB26.5060701@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=bernds@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=jason@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).