From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103731 invoked by alias); 26 Jul 2017 16:35:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103338 invoked by uid 89); 26 Jul 2017 16:35:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=hm, ages, H*i:sk:1501086, H*f:sk:1501086 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 16:35:28 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id ED6728139D; Wed, 26 Jul 2017 18:35:25 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6aHjrLfNVZmM; Wed, 26 Jul 2017 18:35:25 +0200 (CEST) Received: from [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838] (cacatoes.act-europe.fr [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id D4B6981398; Wed, 26 Jul 2017 18:35:25 +0200 (CEST) Subject: Re: [PATCH 1/2] Introduce testsuite support to run Python tests To: David Malcolm , gcc-patches@gcc.gnu.org References: <20170726160040.6516-1-derodat@adacore.com> <20170726160040.6516-2-derodat@adacore.com> <1501086319.10760.56.camel@redhat.com> From: Pierre-Marie de Rodat Message-ID: <52320c0f-3006-5192-5200-38bd91319e75@adacore.com> Date: Wed, 26 Jul 2017 16:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1501086319.10760.56.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01685.txt.bz2 On 07/26/2017 06:25 PM, David Malcolm wrote: > str.format was introduced in Python 2.6, so presumably the minimum > python 2 version here is at least 2.6+; for Python 3 I believe it was > present in Python 3.0 onwards. Hm… Python 2.6 is fairly old: last binary release was ages ago, last source release was in 2013. Do you think it’s worth supporting it? >> +def check(predicate, message): >> + """ >> + If `predicate` is True, emit a PASS message, otherwise emit a >> FAIL one. > > A very nitpicky nitpick: this comment should be spelled as "is true" > (lowercase), rather than "is True" since the requirement is that > predicate's "truth value" is true, rather than predicate *is* the > boolean "True" singleton; e.g. if someone passes in an int as > predicate, its nonzero-ness would be used, rather than always being > false (since no int *is* the boolean singleton "True"). I agree with you: I updated the patch on my machine. Thank you! -- Pierre-Marie de Rodat