From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8804 invoked by alias); 23 Sep 2013 14:54:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8784 invoked by uid 89); 23 Sep 2013 14:54:54 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Sep 2013 14:54:54 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: aserp1040.oracle.com Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8NEspnP031789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 Sep 2013 14:54:51 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NEsoXS001888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Sep 2013 14:54:50 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NEsopq001868; Mon, 23 Sep 2013 14:54:50 GMT Received: from Paolos-MacBook-Air.local (/12.39.17.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 23 Sep 2013 07:54:49 -0700 Message-ID: <52405639.8030306@oracle.com> Date: Mon, 23 Sep 2013 15:26:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Paul Pluzhnikov CC: Andreas Schwab , =?ISO-8859-1?Q?Daniel_Kr=FCgler?= , gcc-patches List , libstdc++ Subject: Re: [patch] Make vector::at() assertion message more useful (try #2) References: <5232E2AF.4000106@oracle.com> <52402567.2080407@oracle.com> <524054C8.3010502@google.com> In-Reply-To: <524054C8.3010502@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg01680.txt.bz2 Hi, On 9/23/13 9:48 AM, Paul Pluzhnikov wrote: > On 9/23/13 4:26 AM, Paolo Carlini wrote: > >>> m68k-linux/./libstdc++-v3/src/.libs/libstdc++.so: undefined reference >>> to `int std::__int_to_char(char*, unsigned int, >>> char const*, std::_Ios_Fmtflags, bool)' > > Reproduced on i686. > Sorry about the trouble ... > >> I would say, either make sure to use only those two in the new >> code > > Testing this patch: In fact, however, that unsigned long long instantiation isn't *unconditionally* available, see locale-inst.cc. I think we have to use unsigned long as a fall back controlled by the same macro. And please add a comment explaining those contortions having to do with the available instantiations. Patch pre-approved. Thanks again, Paolo.