From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19067 invoked by alias); 23 Sep 2013 15:29:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19030 invoked by uid 89); 23 Sep 2013 15:29:45 -0000 Received: from mail-yh0-f41.google.com (HELO mail-yh0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 23 Sep 2013 15:29:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mail-yh0-f41.google.com Received: by mail-yh0-f41.google.com with SMTP id f73so1395490yha.0 for ; Mon, 23 Sep 2013 08:29:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=rKQkNk9iXQrI7TcZ+2E8pMQqtoo3rBquT7bAH0SVhVY=; b=OEUdsjo0k8qfx4mLArRXu9QNH3NQ4jqXTZca++0SoxoMBma20kTbWN5PfQOxO+Hdt+ L+Jevn6MkWMoqC1lC7qrvfiEfM7Qzhzn1+lOcxxVfuyDqM+PSCSz15ciBS/ZzimEgfQ3 k9b8QeoTuwL/CUcZwsfIkyQ+LdGw9hhU2HF6eYJ3oLulr0d/UByXi8HfSWNh1SIYHtLD Sy2cJoEoVwJbNZf7E2pkoeugDFvk7GiCsDal8ceHRppQauDmXhmAzXXgoeqtwxaAv9AB 3nmZ8OtmsN06wI9UamPsRdUxfxq6zoCW3R0dG4ny7jP365HOjTEdbE2/rihTyKPrYxLo geNA== X-Gm-Message-State: ALoCoQm2/5ngvk3gkrMIAiTuxTOxcEbtmYtwIEKyoXA2jo8LmuTzSuFn9a6vEq1If8XtJxYlEPBc81Xjt+3QiWs8HerVzL+Fq4iQo50dF5UdnCCEIaKYwQ0GIDSlubYbIBao/WLWL2EcADoOPiJS8M4r+gJ/QzJuIGunxGXSZU0N2yeguvXiTnKQ3Q25nQ+vSRBmZ9Ch7Kxd7TUW19jG9SCEiF3H288Q2w== X-Received: by 10.236.86.42 with SMTP id v30mr593878yhe.92.1379950183313; Mon, 23 Sep 2013 08:29:43 -0700 (PDT) Received: from elbrus-m2.roam.corp.google.com ([172.16.55.142]) by mx.google.com with ESMTPSA id 48sm36863417yhq.11.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Sep 2013 08:29:42 -0700 (PDT) Message-ID: <52405E64.7060002@google.com> Date: Mon, 23 Sep 2013 16:21:00 -0000 From: Paul Pluzhnikov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Paolo Carlini CC: Andreas Schwab , =?ISO-8859-1?Q?Daniel_Kr=FCgler?= , gcc-patches List , libstdc++ Subject: Re: [patch] Make vector::at() assertion message more useful (try #2) References: <5232E2AF.4000106@oracle.com> <52402567.2080407@oracle.com> <524054C8.3010502@google.com> In-Reply-To: <524054C8.3010502@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg01685.txt.bz2 On 9/23/13 7:48 AM, Paul Pluzhnikov wrote: > Testing this patch: libstdc++ tests finished with RUNTESTFLAGS='--target_board=unix\{-m32,-m64\}' Committed as r202832. Sorry about the trouble. -- 2013-09-23 Paul Pluzhnikov * src/c++11/snprintf_lite.cc (__concat_size_t): Use only std::__int_to_char() Index: libstdc++-v3/src/c++11/snprintf_lite.cc =================================================================== --- libstdc++-v3/src/c++11/snprintf_lite.cc (revision 202830) +++ libstdc++-v3/src/c++11/snprintf_lite.cc (working copy) @@ -70,9 +70,10 @@ int __concat_size_t(char *__buf, size_t __bufsize, size_t __val) { // Long enough for decimal representation. - int __ilen = 3 * sizeof(__val); + unsigned long long __val_ull = __val; + int __ilen = 3 * sizeof(__val_ull); char *__cs = static_cast(__builtin_alloca(__ilen)); - size_t __len = std::__int_to_char(__cs + __ilen, __val, + size_t __len = std::__int_to_char(__cs + __ilen, __val_ull, std::__num_base::_S_atoms_out, std::ios_base::dec, true); if (__bufsize < __len)