From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-349683-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8307 invoked by alias); 23 Sep 2013 16:24:49 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 8286 invoked by uid 89); 23 Sep 2013 16:24:48 -0000
Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Sep 2013 16:24:48 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_SOFTFAIL,UNPARSEABLE_RELAY autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: userp1040.oracle.com
Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])	by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8NGOjT6025393	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 23 Sep 2013 16:24:45 GMT
Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230])	by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NGOi7m022970	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Mon, 23 Sep 2013 16:24:44 GMT
Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54])	by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8NGOi22022966;	Mon, 23 Sep 2013 16:24:44 GMT
Received: from Paolos-MacBook-Air.local (/12.39.17.2)	by default (Oracle Beehive Gateway v4.0)	with ESMTP ; Mon, 23 Sep 2013 09:24:44 -0700
Message-ID: <52406B4B.1070507@oracle.com>
Date: Mon, 23 Sep 2013 17:00:00 -0000
From: Paolo Carlini <paolo.carlini@oracle.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
To: Paul Pluzhnikov <ppluzhnikov@google.com>
CC: Andreas Schwab <schwab@suse.de>,        =?ISO-8859-1?Q?Daniel_Kr=FCgler?= <daniel.kruegler@gmail.com>,        gcc-patches List <gcc-patches@gcc.gnu.org>,        libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [patch] Make vector::at() assertion message more useful (try #2)
References: <ye6qhae0qpf8.fsf@elbrus2.mtv.corp.google.com> <CAGNvRgDfHf6pYmBYC66HHhj6RobhiaiAAVEKj1FDxSWGxbYFTg@mail.gmail.com> <CALoOobMf3u8R_DVW5b2eRy05fBpB5unhriLMYdUEkT_E3DwtaA@mail.gmail.com> <CAGNvRgD6mK=-n7QhK=-NtfXZHOpCniXKc-riWUNfqZeVa8xufQ@mail.gmail.com> <CALoOobO6XEsrSM6jJFCQ=n00iY8qM=eujs-=LixNZyuya5f-cA@mail.gmail.com> <5232E2AF.4000106@oracle.com> <CALoOobMejGJLVVCszP8Joa+4B21UbvK4chyFUnjiCNPP0GJF0A@mail.gmail.com> <mvma9j35377.fsf@hawking.suse.de> <52402567.2080407@oracle.com> <524054C8.3010502@google.com> <52405639.8030306@oracle.com> <524065FA.2020301@google.com>
In-Reply-To: <524065FA.2020301@google.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-09/txt/msg01690.txt.bz2

Hi,

On 9/23/13 11:02 AM, Paul Pluzhnikov wrote:
> On 9/23/13 7:54 AM, Paolo Carlini wrote:
>
>>> Testing this patch:
>> In fact, however, that unsigned long long instantiation isn't
>> *unconditionally* available, see locale-inst.cc.
>
> Thanks,
>
>> I think we have to use
>> unsigned long as a fall back controlled by the same macro. And please
>> add a comment explaining those contortions having to do with the
>> available instantiations. Patch pre-approved.
>
> Does this look right?
Yes. Nit, in the comment I would also explicitly mention locale-inst.cc.

Thanks!
Paolo.