From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 168F23888C6E for ; Sat, 17 Dec 2022 00:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 168F23888C6E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671236109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xp7w2OUpkgoh3nGJ5oKC2FDM+M8Gfq8gl9TtK9m+wL8=; b=Jczfqqg9JoE88nxG49alzv4ivh6Oq4k9FvaygF3uOzksNSVkY/3IxHFGRoZDO5y85wIU/7 ec93JF6KkFkAdDFkfs4chwuotSzrgx1tcPdDUfoItUSJlPSFtsILHbSy61+0Hn64N1I3cf qjMDbJ9PMkmEB5iAtnqQiROU2n5c2NA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-103-YfAOxaxkN7-cbetvwEYZwg-1; Fri, 16 Dec 2022 19:15:08 -0500 X-MC-Unique: YfAOxaxkN7-cbetvwEYZwg-1 Received: by mail-qk1-f197.google.com with SMTP id h8-20020a05620a284800b006b5c98f09fbso2992630qkp.21 for ; Fri, 16 Dec 2022 16:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xp7w2OUpkgoh3nGJ5oKC2FDM+M8Gfq8gl9TtK9m+wL8=; b=4ehYM9veZVSyLeZQLeFYS3IBG9h7R6dG4VeSPVU/pdEntGPfxbY468TjtDYaRPU0ea qcJRlIq0EPsU7uIkFdVm5ILOz7pTtbolzoDkjiXdLNxXzHex+iyGBjVoGk+dpai+7hn2 Lm2gJ4g/44BuWCUMIf+SDFef71BS2zo7Mjd8spSAdQJN/cW4786qOg+sZbd6UyxTiUnz QTVBwYgTGX1yI5ZPu5ARkF1cai4nSG9c/B2WmKn0ZZj52qA6T7hG19QEItym00xAz9V6 damkVM04O5EoG8BnAsInf6mMO/JWjCLPOimV4IkN2ZgA80LODgE9dfVZA5nZBozpQePH doHg== X-Gm-Message-State: ANoB5pkLzs1meAMCoeEX8r1rDe9+AEvXt4fkNTy9Ysu9QE/61XBnUn5M mvkkeHm+Z5ivanXki4wEyC73PthqXalZLdeYeKXcIkB472b6qe98QSn/9UARATvjH0oIYlXl0gK 20v8/Vbqbzcrm4d8qOg== X-Received: by 2002:ac8:4a86:0:b0:3a6:a7f6:701d with SMTP id l6-20020ac84a86000000b003a6a7f6701dmr48419962qtq.36.1671236108193; Fri, 16 Dec 2022 16:15:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6pg4V7FDXqi1WHF0Mb7/KJbKpN7HxphmwBrd13oKUibJGDHi8O4uA+52T8FcphRAJLZ56hRQ== X-Received: by 2002:ac8:4a86:0:b0:3a6:a7f6:701d with SMTP id l6-20020ac84a86000000b003a6a7f6701dmr48419945qtq.36.1671236107949; Fri, 16 Dec 2022 16:15:07 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id k8-20020a05620a414800b006fc8fc061f7sm2528278qko.129.2022.12.16.16.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 16:15:07 -0800 (PST) Message-ID: <524ae656-1ab3-090d-8183-8a25f03301aa@redhat.com> Date: Fri, 16 Dec 2022 19:15:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] c-family: Fix ICE with -Wsuggest-attribute [PR98487] To: Marek Polacek , GCC Patches Cc: Joseph Myers , Jakub Jelinek References: <20221216182817.295303-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20221216182817.295303-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TRACKER_ID,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/16/22 13:28, Marek Polacek wrote: > Here we crash because check_function_format was using TREE_PURPOSE > directly rather than using get_attribute_name. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. > PR c/98487 > > gcc/c-family/ChangeLog: > > * c-format.cc (check_function_format): Use get_attribute_name. > > gcc/testsuite/ChangeLog: > > * c-c++-common/Wsuggest-attribute-1.c: New test. > --- > gcc/c-family/c-format.cc | 2 +- > .../c-c++-common/Wsuggest-attribute-1.c | 36 +++++++++++++++++++ > 2 files changed, 37 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c > > diff --git a/gcc/c-family/c-format.cc b/gcc/c-family/c-format.cc > index 01adea4ff41..08643c5da7a 100644 > --- a/gcc/c-family/c-format.cc > +++ b/gcc/c-family/c-format.cc > @@ -1215,7 +1215,7 @@ check_function_format (const_tree fn, tree attrs, int nargs, > for (c = TYPE_ATTRIBUTES (TREE_TYPE (current_function_decl)); > c; > c = TREE_CHAIN (c)) > - if (is_attribute_p ("format", TREE_PURPOSE (c)) > + if (is_attribute_p ("format", get_attribute_name (c)) > && (decode_format_type (IDENTIFIER_POINTER > (TREE_VALUE (TREE_VALUE (c)))) > == info.format_type)) > diff --git a/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c b/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c > new file mode 100644 > index 00000000000..8b5b398fb78 > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c > @@ -0,0 +1,36 @@ > +/* PR c/98487 */ > +/* { dg-do compile { target { c || c++11 } } } */ > +/* { dg-options "-Wsuggest-attribute=format" } */ > + > +#include > + > +[[gnu::__format__(__printf__, 1, 2)]] > +void > +do_printf(const char * const a0, ...) > +{ > + va_list ap; > + va_start(ap, a0); > + __builtin_vprintf(a0, ap); > + va_end(ap); > +} > + > +[[gnu::__format__(__scanf__, 1, 2)]] > +void > +do_scanf(const char * const a0, ...) > +{ > + va_list ap; > + va_start(ap, a0); > + __builtin_vscanf(a0, ap); > + va_end(ap); > +} > + > +struct tm; > + > +[[gnu::__format__(__strftime__, 1, 0)]] > +void > +do_strftime(const char * const a0, struct tm * a1) > +{ > + char buff[256]; > + __builtin_strftime(buff, sizeof(buff), a0, a1); > + __builtin_puts(buff); > +} > > base-commit: b50fe16a3b2214c418ecc5febc0bb21bc17912b7