From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 3172F3857C5D for ; Thu, 21 Oct 2021 13:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3172F3857C5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D921F1FD4F; Thu, 21 Oct 2021 13:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634822042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KBDxHKhXtiFj/5YbYeD4OcMfPCTNvFY3P7aqVz5feU=; b=zHT7jzBLVaZQ0FmfJzZjgTBM82CTyESbZ+PD79TzBfgIUYq2+zU5xHMW+Nb4789TD+XIOf 1On6mmeWvYZoW/C8iYB3JzZAT5n1scd0C1Sej6djLbWSWQfHh7ctMpTKax4BhyOuWIvfS4 9c6x7tO0NrwW9tTrCiUtYsQ6/tYy+4Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634822042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KBDxHKhXtiFj/5YbYeD4OcMfPCTNvFY3P7aqVz5feU=; b=cAcpJmkDGe3huEm9WnMycWvkJI6uo8/FvRBLycKdoPae8vfIy022e/DiCXJ6VrZyXIc8VH KHs4AlldyNKCSoCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C231D13BA5; Thu, 21 Oct 2021 13:14:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ifhSLppncWFgHAAAMHmgww (envelope-from ); Thu, 21 Oct 2021 13:14:02 +0000 Content-Type: multipart/mixed; boundary="------------sl0LTHJ10fG8f9LLYm0Zm8pO" Message-ID: <525f12af-e92c-d6c4-462d-cb63b9f402b7@suse.cz> Date: Thu, 21 Oct 2021 15:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] options: Fix variable tracking option processing. Content-Language: en-US To: Richard Biener Cc: GCC Patches References: <202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz> <0ea9882e-8d7c-f6d4-9262-50e2b3ae5e6c@suse.cz> <163c4fd6-5c81-0a4f-5d5a-c2a06c275fa5@suse.cz> <858d6ffd-11c2-474d-11c4-24e8af4ca291@suse.cz> <6a5d130e-2ffe-6dc5-723e-f6cc30cd8618@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 13:14:08 -0000 This is a multi-part message in MIME format. --------------sl0LTHJ10fG8f9LLYm0Zm8pO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/21/21 11:57, Richard Biener wrote: > which previously affected debug_nonbind_markers_p. I think it makes > sense to move > the above to finish_options as well. I suppose -help doesn't correctly dump > the -g enabled state for -gtoggle at the moment? All right, works for me. The updated patch was tested on nvptx cross compiler and can bootstrap on x86_64-linux-gnu and survives regression tests. The -g option is showed in -Q --help=common as: -g So no option value is displayed. Is the patch fine now? Thanks, Martin --------------sl0LTHJ10fG8f9LLYm0Zm8pO Content-Type: text/x-patch; charset=UTF-8; name="0001-options-Fix-variable-tracking-option-processing.patch" Content-Disposition: attachment; filename*0="0001-options-Fix-variable-tracking-option-processing.patch" Content-Transfer-Encoding: base64 RnJvbSBkYTI0ZTUxYzhlMTA4MzczMjU2ZjExMDZmZTQ0NzhiOTE5MTg5Yzk5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUaHUsIDE0IE9jdCAyMDIxIDE0OjU3OjE4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g b3B0aW9uczogRml4IHZhcmlhYmxlIHRyYWNraW5nIG9wdGlvbiBwcm9jZXNzaW5nLgoKCVBS IGRlYnVnLzEwMjU4NQoJUFIgYm9vdHN0cmFwLzEwMjc2NgoKZ2NjL0NoYW5nZUxvZzoKCgkq IG9wdHMuYyAoZmluaXNoX29wdGlvbnMpOiBQcm9jZXNzIGZsYWdfdmFyX3RyYWNraW5nKiBv cHRpb25zCgloZXJlIGFzIHRoZXkgY2FuIGJlIGFkanVzdGVkIGJ5IG9wdGltaXplIGF0dHJp YnV0ZS4KCVByb2Nlc3MgYWxzbyBmbGFnX3N5bnRheF9vbmx5IGFuZCBmbGFnX2d0b2dnbGUu CgkqIHRvcGxldi5jIChwcm9jZXNzX29wdGlvbnMpOiBSZW1vdmUgaXQgaGVyZS4KCSogY29t bW9uLm9wdDogTWFrZSBkZWJ1Z19ub25iaW5kX21hcmtlcnNfcCBhcyBQZXJGdW5jdGlvbgoJ YXR0cmlidXRlIGFzIGl0IGRlcGVuZHMgb24gb3B0aW1pemF0aW9uIGxldmVsLgoKZ2NjL3Rl c3RzdWl0ZS9DaGFuZ2VMb2c6CgoJKiBnY2MuZGcvcHIxMDI1ODUuYzogTmV3IHRlc3QuCi0t LQogZ2NjL2NvbW1vbi5vcHQgICAgICAgICAgICAgICAgICB8ICAyICstCiBnY2Mvb3B0cy5j ICAgICAgICAgICAgICAgICAgICAgIHwgNDUgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwogZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIxMDI1ODUuYyB8ICA2ICsrKysrCiBnY2Mv dG9wbGV2LmMgICAgICAgICAgICAgICAgICAgIHwgNDcgKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiA0IGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDQ3IGRl bGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvZ2NjLmRnL3By MTAyNTg1LmMKCmRpZmYgLS1naXQgYS9nY2MvY29tbW9uLm9wdCBiL2djYy9jb21tb24ub3B0 CmluZGV4IGEyYWY3ZmIzNmUwLi5jNGE3N2Y2NWFhMiAxMDA2NDQKLS0tIGEvZ2NjL2NvbW1v bi5vcHQKKysrIGIvZ2NjL2NvbW1vbi5vcHQKQEAgLTMyODQsNyArMzI4NCw3IEBAIENvbW1v biBEcml2ZXIgSm9pbmVkT3JNaXNzaW5nIE5lZ2F0aXZlKGd2bXMpCiBHZW5lcmF0ZSBkZWJ1 ZyBpbmZvcm1hdGlvbiBpbiBleHRlbmRlZCBTVEFCUyBmb3JtYXQuCiAKIGdzdGF0ZW1lbnQt ZnJvbnRpZXJzCi1Db21tb24gRHJpdmVyIFZhcihkZWJ1Z19ub25iaW5kX21hcmtlcnNfcCkK K0NvbW1vbiBEcml2ZXIgVmFyKGRlYnVnX25vbmJpbmRfbWFya2Vyc19wKSBQZXJGdW5jdGlv bgogRW1pdCBwcm9ncmVzc2l2ZSByZWNvbW1lbmRlZCBicmVha3BvaW50IGxvY2F0aW9ucy4K IAogZ3N0cmljdC1kd2FyZgpkaWZmIC0tZ2l0IGEvZ2NjL29wdHMuYyBiL2djYy9vcHRzLmMK aW5kZXggNjVmZTE5MmExOTguLjQ0NzJjZWMxYjk4IDEwMDY0NAotLS0gYS9nY2Mvb3B0cy5j CisrKyBiL2djYy9vcHRzLmMKQEAgLTEzNDksNiArMTM0OSw1MSBAQCBmaW5pc2hfb3B0aW9u cyAoc3RydWN0IGdjY19vcHRpb25zICpvcHRzLCBzdHJ1Y3QgZ2NjX29wdGlvbnMgKm9wdHNf c2V0LAogICAgIFNFVF9PUFRJT05fSUZfVU5TRVQgKG9wdHMsIG9wdHNfc2V0LCBmbGFnX3Zl Y3RfY29zdF9tb2RlbCwKIAkJCSBWRUNUX0NPU1RfTU9ERUxfQ0hFQVApOwogCisgIC8qIE9u ZSBjb3VsZCB1c2UgRW5hYmxlZEJ5LCBidXQgaXQgd291bGQgbGVhZCB0byBhIGNpcmN1bGFy IGRlcGVuZGVuY3kuICAqLworICBpZiAoIU9QVElPTl9TRVRfUCAoZmxhZ192YXJfdHJhY2tp bmdfdW5pbml0KSkKKyAgICAgZmxhZ192YXJfdHJhY2tpbmdfdW5pbml0ID0gZmxhZ192YXJf dHJhY2tpbmc7CisKKyAgaWYgKCFPUFRJT05fU0VUX1AgKGZsYWdfdmFyX3RyYWNraW5nX2Fz c2lnbm1lbnRzKSkKKyAgICBmbGFnX3Zhcl90cmFja2luZ19hc3NpZ25tZW50cworICAgICAg PSAoZmxhZ192YXJfdHJhY2tpbmcKKwkgJiYgIShmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5n IHx8IGZsYWdfc2VsZWN0aXZlX3NjaGVkdWxpbmcyKSk7CisKKyAgaWYgKGZsYWdfdmFyX3Ry YWNraW5nX2Fzc2lnbm1lbnRzX3RvZ2dsZSkKKyAgICBmbGFnX3Zhcl90cmFja2luZ19hc3Np Z25tZW50cyA9ICFmbGFnX3Zhcl90cmFja2luZ19hc3NpZ25tZW50czsKKworICBpZiAoZmxh Z192YXJfdHJhY2tpbmdfYXNzaWdubWVudHMgJiYgIWZsYWdfdmFyX3RyYWNraW5nKQorICAg IGZsYWdfdmFyX3RyYWNraW5nID0gZmxhZ192YXJfdHJhY2tpbmdfYXNzaWdubWVudHMgPSAt MTsKKworICBpZiAoZmxhZ192YXJfdHJhY2tpbmdfYXNzaWdubWVudHMKKyAgICAgICYmIChm bGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nIHx8IGZsYWdfc2VsZWN0aXZlX3NjaGVkdWxpbmcy KSkKKyAgICB3YXJuaW5nX2F0IChsb2MsIDAsCisJCSJ2YXItdHJhY2tpbmctYXNzaWdubWVu dHMgY2hhbmdlcyBzZWxlY3RpdmUgc2NoZWR1bGluZyIpOworCisgIGlmIChmbGFnX3N5bnRh eF9vbmx5KQorICAgIHsKKyAgICAgIHdyaXRlX3N5bWJvbHMgPSBOT19ERUJVRzsKKyAgICAg IHByb2ZpbGVfZmxhZyA9IDA7CisgICAgfQorCisgIGlmIChmbGFnX2d0b2dnbGUpCisgICAg eworICAgICAgaWYgKGRlYnVnX2luZm9fbGV2ZWwgPT0gRElORk9fTEVWRUxfTk9ORSkKKwl7 CisJICBkZWJ1Z19pbmZvX2xldmVsID0gRElORk9fTEVWRUxfTk9STUFMOworCisJICBpZiAo d3JpdGVfc3ltYm9scyA9PSBOT19ERUJVRykKKwkgICAgd3JpdGVfc3ltYm9scyA9IFBSRUZF UlJFRF9ERUJVR0dJTkdfVFlQRTsKKwl9CisgICAgICBlbHNlCisJZGVidWdfaW5mb19sZXZl bCA9IERJTkZPX0xFVkVMX05PTkU7CisgICAgfQorCisgIGlmICghT1BUSU9OX1NFVF9QIChk ZWJ1Z19ub25iaW5kX21hcmtlcnNfcCkpCisgICAgZGVidWdfbm9uYmluZF9tYXJrZXJzX3AK KyAgICAgID0gKG9wdGltaXplCisJICYmIGRlYnVnX2luZm9fbGV2ZWwgPj0gRElORk9fTEVW RUxfTk9STUFMCisJICYmIGR3YXJmX2RlYnVnaW5mb19wICgpCisJICYmICEoZmxhZ19zZWxl Y3RpdmVfc2NoZWR1bGluZyB8fCBmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nMikpOwogfQog CiAjZGVmaW5lIExFRlRfQ09MVU1OCTI3CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dj Yy5kZy9wcjEwMjU4NS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIxMDI1ODUuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uZWZkMDY2YjRhNGUKLS0tIC9k ZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjEwMjU4NS5jCkBAIC0wLDAg KzEsNiBAQAorLyogUFIgZGVidWcvMTAyNTg1ICovCisvKiB7IGRnLWRvIGNvbXBpbGUgfSAq LworLyogeyBkZy1vcHRpb25zICItZnZhci10cmFja2luZy1hc3NpZ25tZW50cyAtZm5vLXZh ci10cmFja2luZyIgfSAqLworCisjcHJhZ21hIEdDQyBvcHRpbWl6ZSAwCit2b2lkIGRfZGVt YW5nbGVfY2FsbGJhY2tfT2coKSB7IGludCBjID0gMDsgfQpkaWZmIC0tZ2l0IGEvZ2NjL3Rv cGxldi5jIGIvZ2NjL3RvcGxldi5jCmluZGV4IGNiNGY4YzQ3MGYwLi40ODZiZDg4MDRmYSAx MDA2NDQKLS0tIGEvZ2NjL3RvcGxldi5jCisrKyBiL2djYy90b3BsZXYuYwpAQCAtMTM3OCwy NSArMTM3OCw2IEBAIHByb2Nlc3Nfb3B0aW9ucyAoYm9vbCBub19iYWNrZW5kKQogCX0KICAg ICB9CiAKLSAgaWYgKGZsYWdfc3ludGF4X29ubHkpCi0gICAgewotICAgICAgd3JpdGVfc3lt Ym9scyA9IE5PX0RFQlVHOwotICAgICAgcHJvZmlsZV9mbGFnID0gMDsKLSAgICB9Ci0KLSAg aWYgKGZsYWdfZ3RvZ2dsZSkKLSAgICB7Ci0gICAgICBpZiAoZGVidWdfaW5mb19sZXZlbCA9 PSBESU5GT19MRVZFTF9OT05FKQotCXsKLQkgIGRlYnVnX2luZm9fbGV2ZWwgPSBESU5GT19M RVZFTF9OT1JNQUw7Ci0KLQkgIGlmICh3cml0ZV9zeW1ib2xzID09IE5PX0RFQlVHKQotCSAg ICB3cml0ZV9zeW1ib2xzID0gUFJFRkVSUkVEX0RFQlVHR0lOR19UWVBFOwotCX0KLSAgICAg IGVsc2UKLQlkZWJ1Z19pbmZvX2xldmVsID0gRElORk9fTEVWRUxfTk9ORTsKLSAgICB9Ci0K ICAgLyogQ1RGIGlzIHN1cHBvcnRlZCBmb3Igb25seSBDIGF0IHRoaXMgdGltZS4gICovCiAg IGlmICghbGFuZ19HTlVfQyAoKQogICAgICAgJiYgY3RmX2RlYnVnX2luZm9fbGV2ZWwgPiBD VEZJTkZPX0xFVkVMX05PTkUpCkBAIC0xNDk5LDYgKzE0ODAsNyBAQCBwcm9jZXNzX29wdGlv bnMgKGJvb2wgbm9fYmFja2VuZCkKIAl9CiAgICAgICBmbGFnX3Zhcl90cmFja2luZyA9IDA7 CiAgICAgICBmbGFnX3Zhcl90cmFja2luZ191bmluaXQgPSAwOworICAgICAgZmxhZ192YXJf dHJhY2tpbmdfYXNzaWdubWVudHMgPSAwOwogICAgIH0KIAogICAvKiBUaGUgZGVidWcgaG9v a3MgYXJlIHVzZWQgdG8gaW1wbGVtZW50IC1mZHVtcC1nby1zcGVjIGJlY2F1c2UgaXQKQEAg LTE1MDcsMzMgKzE0ODksNiBAQCBwcm9jZXNzX29wdGlvbnMgKGJvb2wgbm9fYmFja2VuZCkK ICAgaWYgKGZsYWdfZHVtcF9nb19zcGVjICE9IE5VTEwpCiAgICAgZGVidWdfaG9va3MgPSBk dW1wX2dvX3NwZWNfaW5pdCAoZmxhZ19kdW1wX2dvX3NwZWMsIGRlYnVnX2hvb2tzKTsKIAot ICAvKiBPbmUgY291bGQgdXNlIEVuYWJsZWRCeSwgYnV0IGl0IHdvdWxkIGxlYWQgdG8gYSBj aXJjdWxhciBkZXBlbmRlbmN5LiAgKi8KLSAgaWYgKCFPUFRJT05fU0VUX1AgKGZsYWdfdmFy X3RyYWNraW5nX3VuaW5pdCkpCi0gICAgIGZsYWdfdmFyX3RyYWNraW5nX3VuaW5pdCA9IGZs YWdfdmFyX3RyYWNraW5nOwotCi0gIGlmICghT1BUSU9OX1NFVF9QIChmbGFnX3Zhcl90cmFj a2luZ19hc3NpZ25tZW50cykpCi0gICAgZmxhZ192YXJfdHJhY2tpbmdfYXNzaWdubWVudHMK LSAgICAgID0gKGZsYWdfdmFyX3RyYWNraW5nCi0JICYmICEoZmxhZ19zZWxlY3RpdmVfc2No ZWR1bGluZyB8fCBmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nMikpOwotCi0gIGlmIChmbGFn X3Zhcl90cmFja2luZ19hc3NpZ25tZW50c190b2dnbGUpCi0gICAgZmxhZ192YXJfdHJhY2tp bmdfYXNzaWdubWVudHMgPSAhZmxhZ192YXJfdHJhY2tpbmdfYXNzaWdubWVudHM7Ci0KLSAg aWYgKGZsYWdfdmFyX3RyYWNraW5nX2Fzc2lnbm1lbnRzICYmICFmbGFnX3Zhcl90cmFja2lu ZykKLSAgICBmbGFnX3Zhcl90cmFja2luZyA9IGZsYWdfdmFyX3RyYWNraW5nX2Fzc2lnbm1l bnRzID0gLTE7Ci0KLSAgaWYgKGZsYWdfdmFyX3RyYWNraW5nX2Fzc2lnbm1lbnRzCi0gICAg ICAmJiAoZmxhZ19zZWxlY3RpdmVfc2NoZWR1bGluZyB8fCBmbGFnX3NlbGVjdGl2ZV9zY2hl ZHVsaW5nMikpCi0gICAgd2FybmluZ19hdCAoVU5LTk9XTl9MT0NBVElPTiwgMCwKLQkJInZh ci10cmFja2luZy1hc3NpZ25tZW50cyBjaGFuZ2VzIHNlbGVjdGl2ZSBzY2hlZHVsaW5nIik7 Ci0KLSAgaWYgKCFPUFRJT05fU0VUX1AgKGRlYnVnX25vbmJpbmRfbWFya2Vyc19wKSkKLSAg ICBkZWJ1Z19ub25iaW5kX21hcmtlcnNfcAotICAgICAgPSAob3B0aW1pemUKLQkgJiYgZGVi dWdfaW5mb19sZXZlbCA+PSBESU5GT19MRVZFTF9OT1JNQUwKLQkgJiYgZHdhcmZfZGVidWdp bmZvX3AgKCkKLQkgJiYgIShmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nIHx8IGZsYWdfc2Vs ZWN0aXZlX3NjaGVkdWxpbmcyKSk7Ci0KICAgaWYgKCFPUFRJT05fU0VUX1AgKGR3YXJmMm91 dF9hc19sb2Nfc3VwcG9ydCkpCiAgICAgZHdhcmYyb3V0X2FzX2xvY19zdXBwb3J0ID0gZHdh cmYyb3V0X2RlZmF1bHRfYXNfbG9jX3N1cHBvcnQgKCk7CiAgIGlmICghT1BUSU9OX1NFVF9Q IChkd2FyZjJvdXRfYXNfbG9jdmlld19zdXBwb3J0KSkKLS0gCjIuMzMuMQoK --------------sl0LTHJ10fG8f9LLYm0Zm8pO--