From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-486453-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 83837 invoked by alias); 26 Sep 2018 14:45:38 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 83704 invoked by uid 89); 26 Sep 2018 14:45:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:594
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 14:45:36 +0000
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id EB23734CB;	Wed, 26 Sep 2018 14:45:34 +0000 (UTC)
Received: from localhost.localdomain (ovpn-112-5.rdu2.redhat.com [10.10.112.5])	by smtp.corp.redhat.com (Postfix) with ESMTP id 9DE2C6149E;	Wed, 26 Sep 2018 14:45:32 +0000 (UTC)
Subject: Re: [PATCH][Middle-end][Version 4]Add a new option to control inlining only on static functions
To: Jason Merrill <jason@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: Qing Zhao <qing.zhao@oracle.com>, gcc Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>, Alexander Monakov <amonakov@ispras.ru>, andrew Pinski <pinskia@gmail.com>, martin Sebor <msebor@gmail.com>, Jan Hubicka <hubicka@ucw.cz>
References: <DF8F7A09-FB59-4945-8A37-AB722E51C33B@oracle.com> <7f314cc6-8cd3-a6f2-27b1-df4ef637542e@gmail.com> <E603F2AF-4C93-4AC3-ABD6-9E1E68ACBFD6@oracle.com> <AEAA5E48-127A-41B7-8082-274948F4BE96@oracle.com> <CADzB+2m7fJ08MPpND9gzn2jf=vLKBxTOV5QJPMKQYcOwhw+pCg@mail.gmail.com> <alpine.LSU.2.20.1809261520360.16707@zhemvz.fhfr.qr> <CADzB+2=OzZ8t67=nD4-FmWWQdrYj2C5_nieaFKNvfTTvSwAERg@mail.gmail.com>
From: Jeff Law <law@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <5263e463-96d1-7fc5-ddff-26efa82df25f@redhat.com>
Date: Wed, 26 Sep 2018 14:46:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CADzB+2=OzZ8t67=nD4-FmWWQdrYj2C5_nieaFKNvfTTvSwAERg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2018-09/txt/msg01556.txt.bz2

On 9/26/18 7:38 AM, Jason Merrill wrote:
> On Wed, Sep 26, 2018 at 9:24 AM, Richard Biener <rguenther@suse.de> wrote:
>> IIRC he explicitely wanted 'static' not 'hidden' linkage.  Not sure
>> what 'internal' would mean in this context.
> 
> I mean internal linkage as in the C and C++ standards.
Since this is primarily for kernel hot patching, I think we're looking
to restrict inlining to functions that have visibility limited to a
compilation unit.

Qing, can you confirm that either way?

Jeff