From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13501 invoked by alias); 25 Oct 2013 18:17:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13485 invoked by uid 89); 25 Oct 2013 18:17:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2013 18:17:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9PIHnnA029756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Oct 2013 14:17:49 -0400 Received: from [10.10.116.17] ([10.10.116.17]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9PIHmT5009826; Fri, 25 Oct 2013 14:17:48 -0400 Message-ID: <526AB5CC.60408@redhat.com> Date: Fri, 25 Oct 2013 19:04:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Marek Polacek CC: GCC Patches , Jakub Jelinek , "Joseph S. Myers" Subject: Re: [PATCH][ubsan] Add VLA bound instrumentation References: <20130912122655.GN23899@redhat.com> <20130925124132.GJ12296@redhat.com> <52697B9D.9000502@redhat.com> <20131025165803.GF27400@redhat.com> In-Reply-To: <20131025165803.GF27400@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg02200.txt.bz2 On 10/25/2013 12:58 PM, Marek Polacek wrote: > I've tried to implement the instrumentation in cp_finish_decl. > However, the problem is with multidimensional arrays, e.g. for > > int x = -1; > int a[1][x]; > > array_of_runtime_bound_p returns false, thus we don't instrument this > at all, nor throw an exception in c++1y mode... Because the above is not valid under the proposed standard C++ VLA support; only the leftmost bound can be variable. I think the right place to handle both ubsan and c++1y VLA checks is in compute_array_index_type, in the block where we're calling variable_size. Jason