From: Jeff Law <jeffreyalaw@gmail.com>
To: Patrick O'Neill <patrick@rivosinc.com>,
Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>,
Brendan Shanks <bshanks@codeweavers.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3] libiberty: Use posix_spawn in pex-unix when available.
Date: Sat, 11 Nov 2023 10:55:40 -0700 [thread overview]
Message-ID: <526afecb-755f-47c9-b509-264dfa4652a0@gmail.com> (raw)
In-Reply-To: <bed1743a-05dd-4bcc-acde-fc59baf87570@rivosinc.com>
On 11/10/23 17:22, Patrick O'Neill wrote:
> On 11/10/23 03:00, Prathamesh Kulkarni wrote:
>
>> On Thu, 5 Oct 2023 at 00:00, Brendan Shanks<bshanks@codeweavers.com> wrote:
>>> Hi,
>>>
>>> This patch implements pex_unix_exec_child using posix_spawn when
>>> available.
>>>
>>> This should especially benefit recent macOS (where vfork just calls
>>> fork), but should have equivalent or faster performance on all
>>> platforms.
>>> In addition, the implementation is substantially simpler than the
>>> vfork+exec code path.
>>>
>>> Tested on x86_64-linux.
>> Hi Brendan,
>> It seems this patch caused the following regressions on aarch64:
>
> I'm also seeing the same failures on risc-v targets bisected to this commit.
My tester flagged it on ppc64le.
I've got Richi's testsuite adjustment in my local tree for testing.
Figure results on ppc64le sometime tomorrow.
jeff
prev parent reply other threads:[~2023-11-11 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 18:28 Brendan Shanks
2023-11-01 18:16 ` Ping: " Brendan Shanks
2023-11-02 8:05 ` Richard Biener
2023-11-10 4:02 ` Jeff Law
2023-11-10 11:00 ` Prathamesh Kulkarni
2023-11-10 13:28 ` Richard Biener
2023-11-11 0:22 ` Patrick O'Neill
2023-11-11 17:55 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526afecb-755f-47c9-b509-264dfa4652a0@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=bshanks@codeweavers.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patrick@rivosinc.com \
--cc=prathamesh.kulkarni@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).