From: Basile Starynkevitch <basile@starynkevitch.net>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)
Date: Thu, 31 Oct 2013 18:43:00 -0000 [thread overview]
Message-ID: <52729DB5.6080903@starynkevitch.net> (raw)
In-Reply-To: <1383236801-13234-1-git-send-email-dmalcolm@redhat.com>
On 10/31/2013 05:26 PM, David Malcolm wrote:
> [Shamelessly hijacking Andrew's thread about gimple.h refactoring,
> since this seems on-topic for that, and I'm keen to hear from Andrew on
> how the following would interact with his work - I *think* our two
> cleanups are orthogonal.
>
> [This is a revised version of the patches sent as:
> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01788.html
> and
> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01954.html
> which got bogged down in discussion of hand-written GTY hooks. This
> patch series updates things to make use of the new support in gengtype
> for simple inheritance schemes]
>
> The gimple statement types are currently implemented using a hand-coded
> C inheritance scheme, with a "union gimple_statement_d" holding the
> various possible structs for a statement.
>
> The following series of patches convert it to a C++ hierarchy, using the
> existing structs, eliminating the union. The "gimple" typedef changes
> from being a
> (union gimple_statement_d *)
> to being a:
> (struct gimple_statement_base *)
Very good idea. But please, document that in some texinfo file, probably
gcc/doc/gimple.texi
Gimple-s are so damn important, even for plugin writers, that a small
but up to date documentation is absolutely essential. You don"t need to
write a lot of doc, just the minimal stuff (which at least tells which
file should the plugin writer look into and list all the relevant classes).
I hope your patches (or similar ones) will be accepted in 4.9
Regards.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
next prev parent reply other threads:[~2013-10-31 18:13 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 5:45 RFC: gimple.[ch] break apart Andrew MacLeod
2013-10-31 6:15 ` Jeff Law
2013-10-31 16:41 ` [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3) David Malcolm
2013-10-31 16:27 ` [PATCH 2/6] Hand-written port of various accessors within gimple.h David Malcolm
2013-11-14 9:53 ` Jeff Law
2013-10-31 16:27 ` [PATCH 4/6] Implement is_a_helper <>::test specializations for various gimple types David Malcolm
2013-11-14 9:41 ` Jeff Law
2013-11-18 19:51 ` David Malcolm
2013-11-18 20:10 ` Andrew MacLeod
2013-11-18 20:15 ` Jeff Law
2013-10-31 16:27 ` [PATCH 1/6] Convert gimple types from a union to C++ inheritance David Malcolm
2013-11-14 23:00 ` Jeff Law
2013-11-19 0:22 ` David Malcolm
2013-11-19 8:49 ` Jeff Law
2013-10-31 16:31 ` [PATCH 3/6] Automated part of conversion of gimple types to use " David Malcolm
2013-11-14 9:43 ` Jeff Law
2013-11-18 22:17 ` [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance) David Malcolm
2013-11-19 8:49 ` Jeff Law
2013-11-19 16:36 ` David Malcolm
2013-11-22 0:27 ` Jakub Jelinek
2013-11-22 0:35 ` Jeff Law
2013-11-22 1:51 ` Jakub Jelinek
2013-11-22 2:52 ` Andrew MacLeod
2013-11-22 3:48 ` David Malcolm
2013-11-25 18:09 ` [PATCH] Fix checking of gimple types David Malcolm
2013-11-25 18:42 ` Michael Matz
2013-11-25 22:18 ` Jeff Law
2013-11-27 8:54 ` David Malcolm
2014-07-23 13:16 ` Thomas Schwinge
2014-07-24 1:50 ` David Malcolm
2014-07-29 8:11 ` Thomas Schwinge
2013-10-31 16:46 ` [PATCH 6/6] Update gdb hooks to reflect changes to " David Malcolm
2013-11-14 9:10 ` Jeff Law
2013-10-31 16:49 ` [PATCH 5/6] Port various places from union access to subclass access David Malcolm
2013-11-14 9:23 ` Jeff Law
2013-11-19 0:52 ` David Malcolm
2013-10-31 18:43 ` Basile Starynkevitch [this message]
2013-11-01 21:36 ` [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3) Andrew MacLeod
2013-11-01 21:41 ` Jakub Jelinek
2013-11-01 21:47 ` Andrew MacLeod
2013-11-01 21:57 ` Jakub Jelinek
2013-11-01 22:58 ` David Malcolm
2013-11-04 13:23 ` Andrew MacLeod
2013-11-04 21:52 ` David Malcolm
2013-11-04 22:09 ` David Malcolm
2013-11-04 22:31 ` Andrew MacLeod
2013-11-05 21:27 ` Jeff Law
2013-11-04 22:43 ` Andrew MacLeod
2013-11-04 22:28 ` Jakub Jelinek
2013-11-04 22:49 ` Andrew MacLeod
2013-11-05 21:09 ` Jeff Law
2013-11-05 11:53 ` Richard Biener
2013-11-05 12:33 ` David Malcolm
2013-11-05 12:52 ` Richard Biener
2013-11-04 14:00 ` Andrew MacLeod
2013-11-04 14:01 ` Jakub Jelinek
2013-11-04 14:15 ` Andrew MacLeod
2013-11-04 18:23 ` Jeff Law
2013-11-01 22:43 ` David Malcolm
2013-11-01 23:43 ` Trevor Saunders
2013-11-04 13:15 ` Andrew MacLeod
2013-11-05 17:23 ` [PATCH] Add gimple subclasses for every gimple code (was Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)) David Malcolm
2013-11-06 16:53 ` Michael Matz
2013-11-07 6:19 ` David Malcolm
2013-11-07 7:08 ` Jeff Law
2013-11-08 19:23 ` David Malcolm
2013-11-14 8:38 ` Jeff Law
2013-11-14 15:06 ` Michael Matz
2013-11-14 18:32 ` David Malcolm
2013-11-15 2:49 ` Jeff Law
2013-11-07 14:57 ` Michael Matz
2013-11-08 0:07 ` Alec Teal
2013-11-08 14:31 ` Michael Matz
2013-11-05 18:22 ` [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3) Andrew MacLeod
2013-11-05 21:33 ` Jeff Law
2013-11-05 22:01 ` David Malcolm
2013-11-05 22:17 ` Jeff Law
2013-11-06 1:14 ` Ian Lance Taylor
2013-11-06 20:49 ` Jeff Law
2013-11-06 20:57 ` Trevor Saunders
2013-11-05 22:24 ` Andrew MacLeod
2013-11-05 22:12 ` Andrew MacLeod
2013-11-06 9:37 ` Richard Biener
2013-11-06 11:20 ` Bernd Schmidt
2013-11-06 11:43 ` Richard Biener
2013-11-06 11:53 ` Jakub Jelinek
2013-11-06 13:14 ` Richard Biener
2013-11-06 13:23 ` Jakub Jelinek
2013-11-06 16:42 ` David Malcolm
2013-11-06 16:55 ` Jakub Jelinek
2013-11-06 18:34 ` Tom Tromey
2013-11-06 19:15 ` Jeff Law
2013-11-06 20:05 ` Tom Tromey
2013-11-06 20:45 ` Jeff Law
2013-11-06 13:31 ` Joseph S. Myers
2013-11-06 21:25 ` Jeff Law
2013-11-06 21:09 ` Jeff Law
2013-11-06 12:42 ` Bernd Schmidt
2013-11-06 21:04 ` Jeff Law
2013-11-06 21:06 ` Andrew MacLeod
2013-11-06 21:52 ` Jeff Law
2013-11-07 10:29 ` Richard Biener
2013-11-07 14:01 ` Joseph S. Myers
2013-11-07 14:42 ` Richard Biener
2013-11-07 14:53 ` Andrew MacLeod
2013-11-10 12:35 ` Richard Sandiford
2013-11-10 15:27 ` Richard Biener
2013-11-06 11:56 ` Eric Botcazou
2013-11-06 20:51 ` Jeff Law
2013-11-06 21:26 ` Jeff Law
2013-11-14 8:40 ` Jeff Law
2013-11-05 16:58 ` [patch] Create gimple-expr..[ch] ... was Re: RFC: gimple.[ch] break apart Andrew MacLeod
2013-11-05 17:52 ` Jeff Law
2013-11-07 10:58 ` Basile Starynkevitch
2013-11-07 13:47 ` Andrew MacLeod
2013-11-07 18:13 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52729DB5.6080903@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=amacleod@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).