From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH][ubsan] Add VLA bound instrumentation
Date: Fri, 01 Nov 2013 17:35:00 -0000 [thread overview]
Message-ID: <5273E64B.8060703@redhat.com> (raw)
In-Reply-To: <20131031182855.GI31396@redhat.com>
On 10/31/2013 02:28 PM, Marek Polacek wrote:
> /* A variable sized array. */
> itype = variable_size (itype);
> +
> + /* We need to stabilize side-effects in VLA sizes for regular array
> + declarations too, not just pointers to arrays. */
> + stabilize_vla_size (itype);
Let's put this after the later call to variable_size, too.
> if (TREE_CODE (itype) != SAVE_EXPR)
> {
> /* Look for SIZEOF_EXPRs in itype and fold them, otherwise
> @@ -8390,6 +8385,31 @@ compute_array_index_type (tree name, tre
> if (found)
> itype = variable_size (fold (newitype));
> }
i.e. here.
> +
> + if (cxx_dialect >= cxx1y)
> + {
> + /* If the VLA bound is larger than half the address space,
> + or less than zero, throw std::bad_array_length. */
> + tree comp = build2 (LT_EXPR, boolean_type_node, itype,
> + ssize_int (-1));
> + comp = build3 (COND_EXPR, void_type_node, comp,
> + throw_bad_array_length (), void_zero_node);
> + finish_expr_stmt (comp);
> + }
> +
> + if ((flag_sanitize & SANITIZE_VLA)
> + /* From C++1y onwards, we throw an exception on a negative
> + length size of an array; see above */
> + && cxx_dialect < cxx1y)
This could be
else if (flag_sanitize & SANITIZE_VLA)
There's another use of stabilize_vla_size in grokdeclarator, that should
be able to go as well.
Jason
next prev parent reply other threads:[~2013-11-01 17:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:38 Marek Polacek
2013-09-12 12:48 ` Marek Polacek
2013-09-12 16:12 ` Joseph S. Myers
2013-09-12 16:20 ` Joseph S. Myers
2013-09-12 17:15 ` Marek Polacek
2013-09-13 10:29 ` Marek Polacek
2013-09-13 11:23 ` Eric Botcazou
2013-09-13 18:01 ` Joseph S. Myers
2013-09-16 11:13 ` Marek Polacek
2013-09-16 13:39 ` Florian Weimer
2013-09-12 16:29 ` Marek Polacek
2013-09-25 13:23 ` Marek Polacek
2013-10-07 20:17 ` Marek Polacek
2013-10-15 13:25 ` Marek Polacek
2013-10-15 15:01 ` Joseph S. Myers
2013-10-24 20:35 ` Jason Merrill
2013-10-25 17:38 ` Marek Polacek
2013-10-25 19:04 ` Jason Merrill
2013-10-25 19:15 ` Marek Polacek
2013-10-25 19:30 ` Jason Merrill
2013-10-30 15:16 ` Marek Polacek
2013-10-30 16:08 ` Jason Merrill
2013-10-30 16:20 ` Marek Polacek
2013-10-30 20:55 ` Mike Stump
2013-10-30 22:46 ` Marek Polacek
2013-10-30 22:50 ` Mike Stump
2013-10-31 11:12 ` Marek Polacek
2013-10-31 3:18 ` Jason Merrill
2013-10-31 19:07 ` Marek Polacek
2013-11-01 17:35 ` Jason Merrill [this message]
2013-11-01 19:10 ` Marek Polacek
2013-11-01 20:39 ` Jason Merrill
2013-11-02 13:06 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5273E64B.8060703@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).