From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22050 invoked by alias); 4 Nov 2013 22:32:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22040 invoked by uid 89); 4 Nov 2013 22:32:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Nov 2013 22:31:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4MViSU004493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Nov 2013 17:31:44 -0500 Received: from [10.10.53.219] (vpn-53-219.rdu2.redhat.com [10.10.53.219]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA4MVhjR026511; Mon, 4 Nov 2013 17:31:43 -0500 Message-ID: <5278204E.9030409@redhat.com> Date: Mon, 04 Nov 2013 22:43:00 -0000 From: Andrew MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: David Malcolm CC: Jakub Jelinek , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3) References: <5271CBF9.2070005@redhat.com> <1383236801-13234-1-git-send-email-dmalcolm@redhat.com> <52741EE2.3030100@redhat.com> <20131101214148.GF27813@tucnak.zalov.cz> <52742162.2010009@redhat.com> <20131101215709.GG27813@tucnak.zalov.cz> <1383346704.5282.44.camel@surprise> <52779EF5.8000401@redhat.com> <1383601413.5282.62.camel@surprise> <1383602624.5282.74.camel@surprise> In-Reply-To: <1383602624.5282.74.camel@surprise> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00301.txt.bz2 On 11/04/2013 05:03 PM, David Malcolm wrote: > I believe it would be easiest to do them one subclass at-a-time e.g. > convert all gimple_call_* functions to accepting a gimple_call, then > another subclass etc - assuming that this approach is blessed by the > core reviewers. > I think the strategy for reworking the gimple stmts needs quite a bit of experimenting to determine what would have to be done and what it would look like, and to get buy in from more people that the end result is indeed acceptable. There are complex situation, and I dont see how we can avoid virtual functions in some cases (at least not easily without resorting to ugly as_a/is_a/dyn_cast functions). So I thinkit needs research. Andrew