From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id CFB3A388E828 for ; Fri, 16 Apr 2021 13:59:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CFB3A388E828 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GDYQNo143134 for ; Fri, 16 Apr 2021 09:59:46 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 37xsvaujjm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 16 Apr 2021 09:59:45 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13GDw61Y014421 for ; Fri, 16 Apr 2021 13:59:43 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 37u3n8cg63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 16 Apr 2021 13:59:43 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13GDxdGd29098368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Apr 2021 13:59:40 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E1A934203F; Fri, 16 Apr 2021 13:59:39 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF7A642041; Fri, 16 Apr 2021 13:59:39 +0000 (GMT) Received: from li-926bd7cc-2dd1-11b2-a85c-f6adc0f5efec.ibm.com (unknown [9.171.86.169]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 16 Apr 2021 13:59:39 +0000 (GMT) From: Robin Dapp Subject: [PATCH] s390/testsuite: Fix oscbreak-1.c. To: gcc-patches@gcc.gnu.org, krebbel@linux.ibm.com Message-ID: <5278ee53-68ce-3c64-3047-b8d65770aa5a@linux.ibm.com> Date: Fri, 16 Apr 2021 15:59:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------376429D470EFA4207CF6F812" Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ugqJyZlb-nzB9WuPx0ImkXkN_AN7LR8j X-Proofpoint-GUID: ugqJyZlb-nzB9WuPx0ImkXkN_AN7LR8j X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-16_07:2021-04-15, 2021-04-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104160102 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2021 13:59:48 -0000 This is a multi-part message in MIME format. --------------376429D470EFA4207CF6F812 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, checking for an osc break is somewhat brittle especially with many passes potentially introducing new insns and moving them around. Therefore, only run the test with -O1 -fschedule-insns in order to limit the influence of other passes. Is it OK? Regards Robin -- gcc/testsuite/ChangeLog: * gcc.target/s390/oscbreak-1.c: Compile with -O1 -fschedule-insns. --------------376429D470EFA4207CF6F812 Content-Type: text/x-patch; charset=UTF-8; name="gcc-oscbreak.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gcc-oscbreak.diff" diff --git a/gcc/testsuite/gcc.target/s390/oscbreak-1.c b/gcc/testsuite/gcc.target/s390/oscbreak-1.c index fdf356c1fd0..0c612531132 100644 --- a/gcc/testsuite/gcc.target/s390/oscbreak-1.c +++ b/gcc/testsuite/gcc.target/s390/oscbreak-1.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O3 -mtune=z13 -dp" } */ +/* { dg-options "-O1 -mtune=z13 -fschedule-insns -dp" } */ void foo (char *a, int b) @@ -10,6 +10,7 @@ foo (char *a, int b) a[i] += 1; } +/* We should not unconditionally emit an osc_break here. */ void bar (char *a, int b) { @@ -22,4 +23,4 @@ bar (char *a, int b) } } -/* { dg-final { scan-assembler "osc_break" } } */ +/* { dg-final { scan-assembler-times "osc_break" 1 } } */ --------------376429D470EFA4207CF6F812--