From: Richard Earnshaw <rearnsha@arm.com>
To: Joey Ye <joey.ye@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] [arm] New option for PIC offset unfixed
Date: Wed, 13 Nov 2013 12:21:00 -0000 [thread overview]
Message-ID: <52835F95.4050805@arm.com> (raw)
In-Reply-To: <000001cee05a$0b8dbd80$22a93880$@arm.com>
On 13/11/13 10:20, Joey Ye wrote:
>>> + if (TARGET_VXWORKS_RTP)
>>> > > + arm_pic_data_is_text_relative = 0;
>> >
>> > Why is this needed? Surely, even a VxWorks user should have the right to
>> > force the compiler to behave differently. You've set things up through
> the
>> > default, now just accept what the user has asked for.
> The reason is that TARGET_VXWORKS_RTP isn't a compile time value to initiate
> arm.opt. Instead it is true only when -mrtp is specified in runtime. Also
> enable text relative may result in runtime error on vxworks, it is better to
> prevent it here.
I'd be happier if this was only done if the command-line option was not
explicitly set on the command line.
R.
next prev parent reply other threads:[~2013-11-13 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 10:12 Joey Ye
2013-11-12 13:37 ` Richard Earnshaw
2013-11-13 9:06 ` Joey Ye
2013-11-13 10:52 ` Richard Earnshaw
2013-11-13 11:16 ` Joey Ye
2013-11-13 11:46 ` Richard Earnshaw
2013-11-13 17:23 ` Joey Ye
2013-11-13 12:21 ` Richard Earnshaw [this message]
[not found] ` <45520D6299C11E4588128526465332BB3BDBAD147A@SAROVARA.Asiapac.Arm.com>
2013-11-13 18:00 ` Richard Earnshaw
2013-11-14 10:09 Joey Ye
2013-11-14 10:48 ` Richard Earnshaw
2013-11-14 12:53 ` Joey Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52835F95.4050805@arm.com \
--to=rearnsha@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joey.ye@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).