From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-354478-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1666 invoked by alias); 14 Nov 2013 10:00:14 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 1551 invoked by uid 89); 14 Nov 2013 10:00:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: service87.mimecast.com
Received: from Unknown (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 10:00:11 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 14 Nov 2013 10:00:02 +0000
Received: from [10.1.208.33] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Thu, 14 Nov 2013 10:00:01 +0000
Message-ID: <52849F21.6030403@arm.com>
Date: Thu, 14 Nov 2013 10:48:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Joey Ye <joey.ye@arm.com>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] [arm] New option for PIC offset unfixed
References: <000001cee112$c9f683c0$5de38b40$@arm.com>
In-Reply-To: <000001cee112$c9f683c0$5de38b40$@arm.com>
X-MC-Unique: 113111410000200301
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg01577.txt.bz2

On 14/11/13 08:23, Joey Ye wrote:
>> -----Original Message-----
>> From: Richard Earnshaw
>> Sent: Thursday, November 14, 2013 0:57
>> To: Joey Ye
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [patch] [arm] New option for PIC offset unfixed
>>
>>> So you are suggesting change like this:
>>> + Target Report Var(arm_pic_data_is_text_relative) Init(-1)
>>>
>>> +   if (arm_pic_data_is_text_relative < 0 && TARGET_VXWORKS_RTP)
>>> +     arm_pic_data_is_text_relative =3D 0;
>>> +   else
>>> +     arm_pic_data_is_text_relative =3D 1;
>>>
>>
>> No, use the global_options_set structure to find out if the user has set
> the
>> value.
> Thank pointing this out. Here is the latest patch with global_options_set
>=20
>=20

This is OK.

However, don't you also need to fix the other references to
TARGET_VXWORKS_RTP; eg pic_offset_arm in arm.md?

R.