From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6277 invoked by alias); 14 Nov 2013 21:51:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6264 invoked by uid 89); 14 Nov 2013 21:51:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 21:51:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAELpKPK025594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Nov 2013 16:51:20 -0500 Received: from stumpy.slc.redhat.com (ovpn-113-161.phx2.redhat.com [10.3.113.161]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAELpJ97013569; Thu, 14 Nov 2013 16:51:19 -0500 Message-ID: <528545D7.3010608@redhat.com> Date: Thu, 14 Nov 2013 23:00:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org, Andrew MacLeod Subject: Re: [PATCH 1/6] Convert gimple types from a union to C++ inheritance References: <5271CBF9.2070005@redhat.com> <1383236801-13234-1-git-send-email-dmalcolm@redhat.com> <1383236801-13234-2-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1383236801-13234-2-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg01694.txt.bz2 On 10/31/13 10:26, David Malcolm wrote: > * Makefile.in (GIMPLE_H): Add dep on is-a.h. Not asking you, but I'd like to hope many of the *_H things in Makefile.in should be going away... > > diff --git a/gcc/Makefile.in b/gcc/Makefile.in > index cc88fb8..7fbb533 100644 > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -887,7 +887,7 @@ BASIC_BLOCK_H = basic-block.h $(PREDICT_H) $(VEC_H) $(FUNCTION_H) \ > cfg-flags.def cfghooks.h > GIMPLE_H = gimple.h gimple.def gsstruct.def pointer-set.h $(VEC_H) \ > $(GGC_H) $(BASIC_BLOCK_H) $(TREE_H) tree-ssa-operands.h \ > - tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) > + tree-ssa-alias.h $(INTERNAL_FN_H) $(HASH_TABLE_H) is-a.h > GCOV_IO_H = gcov-io.h gcov-iov.h auto-host.h > RECOG_H = recog.h > EMIT_RTL_H = emit-rtl.h Ugh. OK I guess. I hate all these _H thingies. Ideally they'll go away at some point. I think their biggest use now is for PLUGIN_HEADERS. But that's not an issue for this patch to go forward. > diff --git a/gcc/ggc.h b/gcc/ggc.h > index b31bc80..bb8f939 100644 > --- a/gcc/ggc.h > +++ b/gcc/ggc.h > @@ -269,10 +269,10 @@ ggc_alloc_cleared_tree_node_stat (size_t s MEM_STAT_DECL) > return (union tree_node *) ggc_internal_cleared_alloc_stat (s PASS_MEM_STAT); > } > > -static inline union gimple_statement_d * > -ggc_alloc_cleared_gimple_statement_d_stat (size_t s MEM_STAT_DECL) > +static inline struct gimple_statement_base * > +ggc_alloc_cleared_gimple_statement_stat (size_t s MEM_STAT_DECL) > { > - return (union gimple_statement_d *) > + return (struct gimple_statement_base *) > ggc_internal_cleared_alloc_stat (s PASS_MEM_STAT); > } Didn't I see something in the last 48hrs indicating that we don't need "static inline" anymore, just "inline"? If so, can you drop the static here since you're changing it already. With that, this, IMO is OK and a definite step forward. Given the contention over this, please give other maintainers 24hrs to object before installing the set. jeff