From: Eric Botcazou <ebotcazou@adacore.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, "H.J. Lu" <hjl.tools@gmail.com>,
Richard Biener <richard.guenther@gmail.com>,
Arnaud Charlet <charlet@adacore.com>
Subject: Re: Fix lto-symtab ICE during Ada LTO bootstrap
Date: Sun, 20 Dec 2015 22:20:00 -0000 [thread overview]
Message-ID: <5296555.IcPf3kD4Th@polaris> (raw)
In-Reply-To: <20151123183655.GB77967@kam.mff.cuni.cz>
> BTW for the LTO type merging issues one could probably just drop those types
> and all derivations to alias set 0. But indeed rewriting them to pointers
> would be better, especially for ABI compatibility.
>
> The Ada ICE I get is:
> Continuing.
> +===========================GNAT BUG DETECTED==============================+
> | 6.0.0 20151122 (experimental) (x86_64-pc-linux-gnu) Assert_Failure
> | atree.adb:6776| Error detected at system.ads:107:4
It's apparently another bug in the DCE pass. From:
<bb 4063>:
# DEBUG id => e_186
_11422 = atree__unchecked_access__node4.localalias.3007 (e_186);
<bb 4064>:
# DEBUG id => NULL
# DEBUG n => _11422
# DEBUG n => NULL
if (_11422 == 0)
goto <bb 4097> (<L255>);
else
goto <bb 4065>;
in phicprop2, we have in cddce2:
Deleting : if (_11422 == 0)
and then:
<bb 4094>:
# DEBUG id => e_186
_11422 = atree__unchecked_access__node4.localalias.3007 (e_186);
<bb 4095>:
# DEBUG id => NULL
# DEBUG n => _11422
# DEBUG n => NULL
# DEBUG id => e_186
goto <bb 4076>;
which is wrong since it's the only exit of the loop in sem_prag.adb:22878:
loop
Set_Warnings_Off
(E, (Chars (Get_Pragma_Arg (Arg1)) =
Name_Off));
-- For OFF case, make entry in warnings off
-- pragma table for later processing. But we do
-- not do that within an instance, since these
-- warnings are about what is needed in the
-- template, not an instance of it.
if Chars (Get_Pragma_Arg (Arg1)) = Name_Off
and then Warn_On_Warnings_Off
and then not In_Instance
then
Warnings_Off_Pragmas.Append ((N, E, Reason));
end if;
if Is_Enumeration_Type (E) then
declare
Lit : Entity_Id;
begin
Lit := First_Literal (E);
while Present (Lit) loop
Set_Warnings_Off (Lit);
Next_Literal (Lit);
end loop;
end;
end if;
exit when No (Homonym (E));
E := Homonym (E);
end loop;
Note that the change you installed is not exactly the patch you had posted, it
contains an additional hunk:
@@ -134,7 +137,7 @@ mark_stmt_necessary (gimple *stmt, bool
gimple_set_plf (stmt, STMT_NECESSARY, true);
if (add_to_worklist)
worklist.safe_push (stmt);
- if (bb_contains_live_stmts && !is_gimple_debug (stmt))
+ if (add_to_worklist && bb_contains_live_stmts && !is_gimple_debug (stmt))
bitmap_set_bit (bb_contains_live_stmts, gimple_bb (stmt)->index);
}
which is not documented in the installed ChangeLog either.
--
Eric Botcazou
next prev parent reply other threads:[~2015-12-20 22:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 18:35 Jan Hubicka
2015-11-22 14:46 ` Eric Botcazou
2015-11-22 15:17 ` Arnaud Charlet
2015-11-23 1:24 ` Jan Hubicka
2015-11-23 9:59 ` Arnaud Charlet
2015-11-23 11:13 ` Eric Botcazou
2015-11-23 11:24 ` Arnaud Charlet
2015-11-23 12:00 ` Eric Botcazou
2015-11-23 13:35 ` Richard Biener
2015-11-23 16:05 ` Eric Botcazou
2015-11-23 16:17 ` H.J. Lu
2015-11-23 16:26 ` Eric Botcazou
2015-11-23 16:31 ` Arnaud Charlet
2015-11-23 19:05 ` Jan Hubicka
2015-11-23 22:29 ` Eric Botcazou
2015-11-23 22:53 ` Jan Hubicka
2015-11-23 23:09 ` Jan Hubicka
2015-12-20 6:54 ` Jan Hubicka
2015-12-20 8:14 ` Eric Botcazou
2015-12-20 22:20 ` Eric Botcazou [this message]
2015-12-21 10:20 ` Eric Botcazou
2015-12-21 14:19 ` Jan Hubicka
2015-12-21 15:16 ` Eric Botcazou
2015-12-21 14:20 ` Jan Hubicka
2015-11-22 18:49 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5296555.IcPf3kD4Th@polaris \
--to=ebotcazou@adacore.com \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).