From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23262 invoked by alias); 5 Dec 2013 15:39:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23197 invoked by uid 89); 5 Dec 2013 15:39:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mo-p00-ob.rzone.de Received: from Unknown (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Dec 2013 15:38:59 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT3ol15ykJcYwRP/XHRipPRQwznuLpg== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by smtp.strato.de (RZmta 32.17 AUTH) with (TLSv1:DHE-RSA-AES256-SHA encrypted) ESMTPSA id 5041b1pB5Fclj4H ; Thu, 5 Dec 2013 16:38:47 +0100 (CET) Message-ID: <52A09E07.2090903@gjlay.de> Date: Thu, 05 Dec 2013 15:39:00 -0000 From: Georg-Johann Lay User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130911 Thunderbird/17.0.9 MIME-Version: 1.0 To: Richard Biener CC: GCC Patches , Denis Chertykov , Eric Weddington Subject: Re: [Patch,avr]: Fix wrong warning PR59396 References: <52A0937F.8020105@gjlay.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00533.txt.bz2 Am 12/05/2013 04:09 PM, schrieb Richard Biener: > On Thu, Dec 5, 2013 at 3:53 PM, Georg-Johann Lay wrote: >> This is a fix of a wrong warning for a bas ISR name. The assumption was >> that if DECL_ASSEMBLER_NAME is set, it would always starts with a *. >> >> This is not the case for LTO compiler where the assembler name is the plain >> name of the function (except an assembler name is set). > > That sounds odd to me. Does the bug reproduce with -fwhole-program? > Or if the interrupt handler is static? > > Richard. Yes, with -fwhole-program the issue persists (except -flto is removed). Same with a static function, both with and without externally_visible. Because externally_visible conflicts static, I also tried without externally_visible, but with no avail. Johann >> Thus, do a more restrictive test if the first character of the function name >> has to be skipped. >> >> Ok to commit? >> >> Johann >> >> >> PR target/59396 >> * config/avr/avr.c (avr_set_current_function): If the first char >> of the function name is skipped, make sure it is actually '*'.