From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29419 invoked by alias); 15 Jan 2014 16:56:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29402 invoked by uid 89); 15 Jan 2014 16:56:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f174.google.com Received: from mail-wi0-f174.google.com (HELO mail-wi0-f174.google.com) (209.85.212.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 16:56:45 +0000 Received: by mail-wi0-f174.google.com with SMTP id g10so4394768wiw.13 for ; Wed, 15 Jan 2014 08:56:42 -0800 (PST) X-Received: by 10.180.205.162 with SMTP id lh2mr3266728wic.57.1389805001838; Wed, 15 Jan 2014 08:56:41 -0800 (PST) Received: from localhost.localdomain (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by mx.google.com with ESMTPSA id ju6sm3762576wjc.1.2014.01.15.08.56.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 Jan 2014 08:56:40 -0800 (PST) Message-ID: <52D6BDC7.1000803@gmail.com> Date: Wed, 15 Jan 2014 16:56:00 -0000 From: =?ISO-8859-1?Q?Fran=E7ois_Dumont?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120829 Thunderbird/15.0 MIME-Version: 1.0 To: "libstdc++@gcc.gnu.org" , gcc-patches Subject: experimental testsuite patch Content-Type: multipart/mixed; boundary="------------070209040404050003050406" X-SW-Source: 2014-01/txt/msg00889.txt.bz2 This is a multi-part message in MIME format. --------------070209040404050003050406 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1447 Hi Here is a patch to partially fix 2 string_view tests. It looks like we can't use 2 dg-options into the same source, one override the over, the dg-options directives have been merged into 1. I also update a script to make the experimental folder part of the folders to look for tests. I don't know if it was intentionally omitted because of the experimental aspect of what is tested, if so just tell me I won't apply this part. Remaining failures in string_view tests in debug mode are all coming from this kind of code: constexpr const _CharT& operator[](size_type __pos) const { _GLIBCXX_DEBUG_ASSERT(__pos <= this->_M_len); return *(this->_M_str + __pos); } In debug mode the _GLIBCXX_DEBUG_ASSERT is activated and the operator cannot be a constexpr anymore. Maybe Ed can tell what should be done, remove the assertion or remove the constexpr (maybe only in debug mode ?) ? 2014-01-15 François Dumont * scripts/create_testsuite_files: Add testsuite/experimental in the list of folders to introspect for tests. * testsuite/experimental/string_view/element_access/wchar_t/2.cc: Merge dg-options directives into one. * testsuite/experimental/string_view/element_access/char/2.cc: Likewise. Remove invalid experimental namespace scope on string_view_type. Tested under Linux x86_64 normal and debug modes. François --------------070209040404050003050406 Content-Type: text/x-patch; name="experimental.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="experimental.patch" Content-length: 1969 Index: scripts/create_testsuite_files =================================================================== --- scripts/create_testsuite_files (revision 206587) +++ scripts/create_testsuite_files (working copy) @@ -32,7 +32,7 @@ # This is the ugly version of "everything but the current directory". It's # what has to happen when find(1) doesn't support -mindepth, or -xtype. dlist=`echo [0-9][0-9]*` -dlist="$dlist abi backward ext performance tr1 tr2 decimal" +dlist="$dlist abi backward ext performance tr1 tr2 decimal experimental" find $dlist "(" -type f -o -type l ")" -name "*.cc" -print > $tmp.01 find $dlist "(" -type f -o -type l ")" -name "*.c" -print > $tmp.02 cat $tmp.01 $tmp.02 | sort > $tmp.1 Index: testsuite/experimental/string_view/element_access/char/2.cc =================================================================== --- testsuite/experimental/string_view/element_access/char/2.cc (revision 206587) +++ testsuite/experimental/string_view/element_access/char/2.cc (working copy) @@ -1,6 +1,5 @@ -// { dg-options "-std=gnu++1y" } // { dg-do run { xfail *-*-* } } -// { dg-options "-O0" } +// { dg-options "-std=gnu++1y -O0" } // { dg-require-debug-mode "" } // Copyright (C) 2013-2014 Free Software Foundation, Inc. @@ -26,6 +25,6 @@ main() { typedef std::experimental::string_view string_view_type; - experimental::string_view_type s; + string_view_type s; s[0]; // abort } Index: testsuite/experimental/string_view/element_access/wchar_t/2.cc =================================================================== --- testsuite/experimental/string_view/element_access/wchar_t/2.cc (revision 206587) +++ testsuite/experimental/string_view/element_access/wchar_t/2.cc (working copy) @@ -1,6 +1,5 @@ -// { dg-options "-std=gnu++1y" } // { dg-do run { xfail *-*-* } } -// { dg-options "-O0" } +// { dg-options "-std=gnu++1y -O0" } // { dg-require-debug-mode "" } // Copyright (C) 2013-2014 Free Software Foundation, Inc. --------------070209040404050003050406--