From: Alex Velenko <Alex.Velenko@arm.com>
To: Richard Earnshaw <Richard.Earnshaw@arm.com>
Cc: "pinskia@gmail.com" <pinskia@gmail.com>,
James Greenhalgh <James.Greenhalgh@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Tejas Belagod <Tejas.Belagod@arm.com>
Subject: Re: [Patch AArch64] Implement Vector Permute Support
Date: Mon, 20 Jan 2014 17:33:00 -0000 [thread overview]
Message-ID: <52DD5DD6.3050302@arm.com> (raw)
In-Reply-To: <52DD05A6.8040209@arm.com>
On 20/01/14 11:16, Richard Earnshaw wrote:
> On 20/01/14 11:15, Alex Velenko wrote:
>> On 17/01/14 15:55, Richard Earnshaw wrote:
>>> On 16/01/14 14:43, Alex Velenko wrote:
>>>> On 14/01/14 15:51, pinskia@gmail.com wrote:
>>>>>
>>>>>
>>>>>> On Jan 14, 2014, at 7:19 AM, Alex Velenko <Alex.Velenko@arm.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> This patch turns off the vec_perm patterns for aarch64_be, this should resolve
>>>>>> the issue highlighted here http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00321.html
>>>>>> With this patch applied, the test case provided in that link compiles without an ICE.
>>>>>>
>>>>>> However, the Big-Endian port is still in development. This patch exposes
>>>>>> another known but unrelated issue with Big-Endian Large-Int modes.
>>>>>>
>>>>>> The patch has been tested on aarch64-none-elf and aarch64_be-none-elf resulting in five
>>>>>> further regression due to the broken implementation of Big-Endian Large-Int modes.
>>>>>>
>>>>>> Kind regards,
>>>>>> Alex Velenko
>>>>>>
>>>>>> gcc/
>>>>>>
>>>>>> 2014-01-14 Alex Velenko <Alex.Velenko@arm.com>
>>>>>>
>>>>>> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>>>>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment.
>>>>>>
>>>>>> gcc/testsuite/
>>>>>>
>>>>>> 2014-01-14 Alex Velenko <Alex.Velenko@arm.com>
>>>>>>
>>>>>> * lib/target-supports.exp
>>>>>> (check_effective_target_vect_perm): Exclude aarch64_be.
>>>>>> (check_effective_target_vect_perm_byte): Likewise.
>>>>>> (check_effective_target_vect_perm_short): Likewise.
>>>>>
>>>>> I think you want to use a function to check if the target is effectively big-endian instead. Internally at Cavium, our elf compiler has big-endian multi-lib.
>>>>>
>>>>> Thanks,
>>>>> Andrew
>>>>>
>>>>>>
>>>>>> <vec-perm.patch>
>>>>>
>>>>
>>>> Hi,
>>>> Here is a vec-perm patch with changes proposed previously.
>>>> Little and Big-Endian tested with no additional issues appearing.
>>>>
>>>> Kind regards,
>>>> Alex
>>>>
>>>> gcc/
>>>>
>>>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>>>
>>>> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment.
>>>>
>>>> gcc/testsuite/
>>>>
>>>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>>>
>>>> * lib/target-supports.exp
>>>> (check_effective_target_vect_perm): Exclude aarch64_be.
>>>> (check_effective_target_vect_perm_byte): Likewise.
>>>> (check_effective_target_vect_perm_short): Likewise.
>>>>
>>>
>>> The patch is missing the hunk for aarch64.c.
>>>
>>>
>>
>> Hi,
>> It is a faulty changelog entry, not patch.
>> Should be:
>>
>> gcc/
>>
>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>
>> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>>
>> gcc/testsuite/
>>
>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>
>> * lib/target-supports.exp
>> (check_effective_target_vect_perm): Exclude aarch64_be.
>> (check_effective_target_vect_perm_byte): Likewise.
>> (check_effective_target_vect_perm_short): Likewise.
>>
>
> On that basis, OK.
>
> R.
>
Can someone, please, commit this patch, as I do not have permissions?
Kind regards,
Alex
next prev parent reply other threads:[~2014-01-20 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 10:31 James Greenhalgh
2012-12-04 10:36 ` [Patch AArch64] Add zip{1, 2}, uzp{1, 2}, trn{1, 2} support for vector permute James Greenhalgh
2012-12-04 22:45 ` Marcus Shawcroft
2012-12-04 22:44 ` [Patch AArch64] Implement Vector Permute Support Marcus Shawcroft
2012-12-06 16:25 ` James Greenhalgh
2014-01-07 23:10 ` Andrew Pinski
[not found] ` <72A61951-68B2-4776-A2B8-05DC4E1F53A7@arm.com>
2014-01-08 0:10 ` Andrew Pinski
2014-01-08 11:00 ` James Greenhalgh
2014-01-14 15:19 ` Alex Velenko
2014-01-14 15:51 ` pinskia
2014-01-16 14:43 ` Alex Velenko
2014-01-17 15:55 ` Richard Earnshaw
2014-01-20 11:15 ` Alex Velenko
2014-01-20 11:17 ` Richard Earnshaw
2014-01-20 17:33 ` Alex Velenko [this message]
2014-01-20 18:36 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DD5DD6.3050302@arm.com \
--to=alex.velenko@arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tejas.Belagod@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).