From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19459 invoked by alias); 20 Jan 2014 17:33:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19448 invoked by uid 89); 20 Jan 2014 17:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 20 Jan 2014 17:33:14 +0000 Received: from [10.1.207.145] (e104458-lin.cambridge.arm.com [10.1.207.145]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id s0KHXA03001664; Mon, 20 Jan 2014 17:33:10 GMT Message-ID: <52DD5DD6.3050302@arm.com> Date: Mon, 20 Jan 2014 17:33:00 -0000 From: Alex Velenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Richard Earnshaw CC: "pinskia@gmail.com" , James Greenhalgh , Marcus Shawcroft , GCC Patches , Tejas Belagod Subject: Re: [Patch AArch64] Implement Vector Permute Support References: <1354617087-31993-1-git-send-email-james.greenhalgh@arm.com> <72A61951-68B2-4776-A2B8-05DC4E1F53A7@arm.com> <20140108105959.GA26808@arm.com> <52D5558E.7040609@arm.com> <15698059-D4C6-4499-A3B2-6C88BDDAFC5E@gmail.com> <52D7F00D.1030206@arm.com> <52D95278.9080408@arm.com> <52DD0563.6030804@arm.com> <52DD05A6.8040209@arm.com> In-Reply-To: <52DD05A6.8040209@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg01267.txt.bz2 On 20/01/14 11:16, Richard Earnshaw wrote: > On 20/01/14 11:15, Alex Velenko wrote: >> On 17/01/14 15:55, Richard Earnshaw wrote: >>> On 16/01/14 14:43, Alex Velenko wrote: >>>> On 14/01/14 15:51, pinskia@gmail.com wrote: >>>>> >>>>> >>>>>> On Jan 14, 2014, at 7:19 AM, Alex Velenko wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> This patch turns off the vec_perm patterns for aarch64_be, this should resolve >>>>>> the issue highlighted here http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00321.html >>>>>> With this patch applied, the test case provided in that link compiles without an ICE. >>>>>> >>>>>> However, the Big-Endian port is still in development. This patch exposes >>>>>> another known but unrelated issue with Big-Endian Large-Int modes. >>>>>> >>>>>> The patch has been tested on aarch64-none-elf and aarch64_be-none-elf resulting in five >>>>>> further regression due to the broken implementation of Big-Endian Large-Int modes. >>>>>> >>>>>> Kind regards, >>>>>> Alex Velenko >>>>>> >>>>>> gcc/ >>>>>> >>>>>> 2014-01-14 Alex Velenko >>>>>> >>>>>> * config/aarch64/aarch64-simd.md (vec_perm): Add BE check. >>>>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment. >>>>>> >>>>>> gcc/testsuite/ >>>>>> >>>>>> 2014-01-14 Alex Velenko >>>>>> >>>>>> * lib/target-supports.exp >>>>>> (check_effective_target_vect_perm): Exclude aarch64_be. >>>>>> (check_effective_target_vect_perm_byte): Likewise. >>>>>> (check_effective_target_vect_perm_short): Likewise. >>>>> >>>>> I think you want to use a function to check if the target is effectively big-endian instead. Internally at Cavium, our elf compiler has big-endian multi-lib. >>>>> >>>>> Thanks, >>>>> Andrew >>>>> >>>>>> >>>>>> >>>>> >>>> >>>> Hi, >>>> Here is a vec-perm patch with changes proposed previously. >>>> Little and Big-Endian tested with no additional issues appearing. >>>> >>>> Kind regards, >>>> Alex >>>> >>>> gcc/ >>>> >>>> 2014-01-16 Alex Velenko >>>> >>>> * config/aarch64/aarch64-simd.md (vec_perm): Add BE check. >>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment. >>>> >>>> gcc/testsuite/ >>>> >>>> 2014-01-16 Alex Velenko >>>> >>>> * lib/target-supports.exp >>>> (check_effective_target_vect_perm): Exclude aarch64_be. >>>> (check_effective_target_vect_perm_byte): Likewise. >>>> (check_effective_target_vect_perm_short): Likewise. >>>> >>> >>> The patch is missing the hunk for aarch64.c. >>> >>> >> >> Hi, >> It is a faulty changelog entry, not patch. >> Should be: >> >> gcc/ >> >> 2014-01-16 Alex Velenko >> >> * config/aarch64/aarch64-simd.md (vec_perm): Add BE check. >> >> gcc/testsuite/ >> >> 2014-01-16 Alex Velenko >> >> * lib/target-supports.exp >> (check_effective_target_vect_perm): Exclude aarch64_be. >> (check_effective_target_vect_perm_byte): Likewise. >> (check_effective_target_vect_perm_short): Likewise. >> > > On that basis, OK. > > R. > Can someone, please, commit this patch, as I do not have permissions? Kind regards, Alex