From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2922 invoked by alias); 3 Feb 2014 15:21:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2897 invoked by uid 89); 3 Feb 2014 15:21:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailout2.w1.samsung.com Received: from mailout2.w1.samsung.com (HELO mailout2.w1.samsung.com) (210.118.77.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Mon, 03 Feb 2014 15:21:32 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0F00CRLENOO580@mailout2.w1.samsung.com>; Mon, 03 Feb 2014 15:21:24 +0000 (GMT) Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id A9.44.18565.7F3BFE25; Mon, 03 Feb 2014 15:21:27 +0000 (GMT) Received: from [106.109.130.57] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N0F003YVENRM930@eusync2.samsung.com>; Mon, 03 Feb 2014 15:21:27 +0000 (GMT) Message-id: <52EFB3F6.4050001@samsung.com> Date: Mon, 03 Feb 2014 15:21:00 -0000 From: Ilmir Usmanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-version: 1.0 To: Jakub Jelinek Cc: Thomas Schwinge , Evgeny Gavrin , GarbuzovViacheslav , Dmitri Botcharnikov , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PING] [PATCH 1/6] [GOMP4] OpenACC 1.0+ support in fortran front-end References: <52E158EF.9050009@samsung.com> <877g9pqmt2.fsf@schwinge.name> <52E65B24.9070403@samsung.com> <87iot5pgqb.fsf@schwinge.name> <52EB8437.3060602@samsung.com> <52EB84C3.4010407@samsung.com> <20140131112219.GK892@tucnak.redhat.com> <52EB8CD5.9070205@samsung.com> In-reply-to: <52EB8CD5.9070205@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00079.txt.bz2 Hi Jakub! On 31.01.2014 15:45, Ilmir Usmanov wrote: > Hi Jakub! > > Thank you for review and quick answer. >> The above are OpenACC specific clauses, so they should have OACC_LIST_*? > I just followed Thomas's style recomendations: >> If we're adding new names for implementing OpenACC things, maybe we >> should also name these OMP_*, to keep things simple to read in the code >> that uses them. > And I agree with him. >>> + case OMP_LIST_DEVICE: type = "DEVICE"; break; >> This one is in OpenMP 4.0 too (though, I didn't get to OpenMP 4.0 / >> fortran >> support yet), so this should be OMP_LIST_DEVICE. > As far as I know, OpenMP device clause requires integer-expression, > not variable-list, so, I think, we can use OMP_LIST_DEVICE to > represent OpenACC device clause. > So, what should I do? Is current naming OK? Or you think it's better to use OACC_ prefix for OpenACC specific stuff in Fortran front-end and OMP_ prefix in middle-end? -- Ilmir.