From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7649 invoked by alias); 4 Feb 2014 10:17:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7638 invoked by uid 89); 4 Feb 2014 10:17:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,FSL_NEW_HELO_USER,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Feb 2014 10:17:53 +0000 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s14AHmvw011976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Feb 2014 10:17:48 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s14AHkTG009518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Feb 2014 10:17:47 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s14AHkpQ018139; Tue, 4 Feb 2014 10:17:46 GMT Received: from [192.168.1.4] (/79.36.197.119) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Feb 2014 02:17:46 -0800 Message-ID: <52F0BE48.7040805@oracle.com> Date: Tue, 04 Feb 2014 10:17:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Rainer Orth CC: "gcc-patches@gcc.gnu.org" , Jason Merrill Subject: Re: [C++ Patch] PR 58846 References: <52E91B33.8040703@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00148.txt.bz2 Hi, On 02/04/2014 10:55 AM, Rainer Orth wrote: > Paolo Carlini writes: > >> a very minor ICE on invalid regression, but since we explicitly allow for >> redeclarations (also see comments in declare_global_var) we may as well >> avoid crashing, at least in mainline. Tested x86_64-linux. > The test FAILs on Solaris which doesn't have __cxa_atexit: > > FAIL: g++.dg/init/dso_handle2.C -std=c++98 (test for errors, line 10) > FAIL: g++.dg/init/dso_handle2.C -std=c++11 (test for errors, line 10) > > Fixed like dso_handle1.C does by forcing -fuse-cxa-atexit. > > Tested with the appropriate runtest invocations on i386-pc-solaris2.11 > and x86_64-unknown-linux-gnu. Ok for mainline? I think it qualifies at obvious. Thanks! Paolo. PS: At some point I had it, when I adapted the testcase from an existing one, then I tried to minimize it ;-/