From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21005 invoked by alias); 9 Feb 2014 23:43:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20900 invoked by uid 89); 9 Feb 2014 23:43:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=unavailable version=3.3.2 X-HELO: mailrelay4.qsc.de Received: from mailrelay4.qsc.de (HELO mailrelay4.qsc.de) (195.158.160.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 09 Feb 2014 23:43:00 +0000 Received: from mx01.qsc.de ([213.148.129.14]) by mailgate4.qsc.de; Mon, 10 Feb 2014 00:42:55 +0100 Received: from archimedes.net-b.de (port-92-194-199-211.dynamic.qsc.de [92.194.199.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.qsc.de (Postfix) with ESMTPS id EC4833CB1C; Mon, 10 Feb 2014 00:42:54 +0100 (CET) Message-ID: <52F8127E.6050102@net-b.de> Date: Sun, 09 Feb 2014 23:43:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Ilmir Usmanov , Thomas Schwinge CC: Evgeny Gavrin , GarbuzovViacheslav , Dmitri Botcharnikov , gcc-patches@gcc.gnu.org, jakub@redhat.com, fortran@gcc.gnu.org Subject: Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end References: <52E158EF.9050009@samsung.com> <877g9pqmt2.fsf@schwinge.name> <52E65B24.9070403@samsung.com> <87iot5pgqb.fsf@schwinge.name> <52EB8437.3060602@samsung.com> <52EB84C3.4010407@samsung.com> <52EB8537.4090708@samsung.com> <52EB8596.2010808@samsung.com> <52EB85F7.5020807@samsung.com> <52EB863B.3010501@samsung.com> In-Reply-To: <52EB863B.3010501@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-cloud-security-sender:burnus@net-b.de X-cloud-security-recipient:gcc-patches@gcc.gnu.org X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mailgate4 with 1E4E71490001 X-cloud-security-connect: mx01.qsc.de[213.148.129.14], TLS=, IP=213.148.129.14 X-cloud-security:scantime:.1912 X-SW-Source: 2014-02/txt/msg00565.txt.bz2 Some general questions to the patch set: * I miss "-fopenacc". Is the support already in the branch? I assume that part is then in c-family/c.opt fortran/lang.opt? * Documentation: Do you also need to update fortran/gfortran.texi and/or fortran/invoke.texi? (I assume that -fopenacc is already documented in docs/invoke.texi) [Search for openmp to find possible spots.] * Intrinsic module "openacc" and "openacc_lib.h": I assume that those will be created as follow up - or do they already exist? If so, do you need to document something in fortran/intrinsic.texi? Or in libgomp.texi? Ilmir Usmanov wrote: > OpenACC 1.0 fortran FE support -- tests. > > gcc/testsuite/gfortran.dg/goacc/ > * goacc.exp: New test directory. > +++ b/gcc/testsuite/gfortran.dg/goacc/branch.f95 > @@ -0,0 +1,55 @@ > +! { dg-do compile } > +! { dg-options "-fopenacc" } Is there a reason that you don't automatically add that flag via goacc.exp? > +! { dg-final { scan-tree-dump "pragma acc data" "original" } } > +! { dg-final { scan-tree-dump "if" "original" } } This one looks rather general. Shouldn't use narrow it down a bit, e.g. by using "scan-tree-dump-times"? > +! { dg-final { scan-tree-dump "to" "original" } } > +! { dg-final { scan-tree-dump "from" "original" } } > +! { dg-final { scan-tree-dump "alloc" "original" } } Ditto. Also spaces before/after the pattern should make it more unique. > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/goacc/goacc.exp > @@ -0,0 +1,36 @@ > +# Load support procs. > +load_lib gfortran-dg.exp > + > +if ![check_effective_target_fopenmp] { > + return > +} I assume that this should be indeed "fopenmp" here and not "fopenacc" as both share libgomp? > +# Main loop. > +gfortran-dg-runtest [lsort \ > + [find $srcdir/$subdir *.\[fF\]{,90,95,03,08} ] ] " -fopenacc -fdump-parse-tree" As you use -fopenacc here, you probably can get rid of it in dg-options. Can't you? I am not sure whether -fdump-parse-tree is needed; on the other hand, it just clutters the *log files. As -fopenmp seemingly can be mixed with -fopenacc, I think it would be nice to have some test cases where !$omp and !$acc are both placed - in either order - before the same Fortran statement. Tobias