From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6633 invoked by alias); 10 Feb 2014 09:45:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6614 invoked by uid 89); 10 Feb 2014 09:45:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailout4.w1.samsung.com Received: from mailout4.w1.samsung.com (HELO mailout4.w1.samsung.com) (210.118.77.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Mon, 10 Feb 2014 09:45:08 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0R0027EXR43S30@mailout4.w1.samsung.com>; Mon, 10 Feb 2014 09:45:04 +0000 (GMT) Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 92.A9.18565.D9F98F25; Mon, 10 Feb 2014 09:45:01 +0000 (GMT) Received: from [106.109.130.57] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N0R008U4XQSTJ90@eusync2.samsung.com>; Mon, 10 Feb 2014 09:45:01 +0000 (GMT) Message-id: <52F89F93.5070401@samsung.com> Date: Mon, 10 Feb 2014 09:45:00 -0000 From: Ilmir Usmanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-version: 1.0 To: Tobias Burnus , Thomas Schwinge Cc: Evgeny Gavrin , GarbuzovViacheslav , Dmitri Botcharnikov , gcc-patches@gcc.gnu.org, jakub@redhat.com, fortran@gcc.gnu.org Subject: Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end References: <52E158EF.9050009@samsung.com> <877g9pqmt2.fsf@schwinge.name> <52E65B24.9070403@samsung.com> <87iot5pgqb.fsf@schwinge.name> <52EB8437.3060602@samsung.com> <52EB84C3.4010407@samsung.com> <52EB8537.4090708@samsung.com> <52EB8596.2010808@samsung.com> <52EB85F7.5020807@samsung.com> <52EB863B.3010501@samsung.com> <52F8127E.6050102@net-b.de> In-reply-to: <52F8127E.6050102@net-b.de> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00580.txt.bz2 Hi Tobias! Thanks a lot for your review! I'm going to test you notes in "reference implementation" (PGI compiler), and then share the results. On 10.02.2014 03:42, Tobias Burnus wrote: > Is there a reason that you don't automatically add that flag via > goacc.exp? > Ditto. Also spaces before/after the pattern should make it more unique. > I assume that this should be indeed "fopenmp" here and not "fopenacc" > as both share libgomp? Yes, I'll fix this, thank you. > > As -fopenmp seemingly can be mixed with -fopenacc, I think it would be > nice to have some test cases where !$omp and !$acc are both placed - > in either order - before the same Fortran statement. > I'm going to test this, too. There are can be some compilcations while using both !$omp and !$acc on single statement. -- Ilmir.