* [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
@ 2014-02-02 19:03 Renlin Li
2014-02-03 10:02 ` Renlin Li
0 siblings, 1 reply; 8+ messages in thread
From: Renlin Li @ 2014-02-02 19:03 UTC (permalink / raw)
To: gcc-patches; +Cc: Marcus Shawcroft, Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
Hi all,
This is a simple patch which resolves
testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression.
Basically, no special operations are needed for vector type i32in128 or
f32in64 in big-endian mode any more due the aarch64 back-end change.
Okay for trunk?
Kind regards,
Renlin Li
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: big-endian-3.diff --]
[-- Type: text/x-patch; name=big-endian-3.diff, Size: 804 bytes --]
diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
index ac94625..24431c6 100644
--- a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
+++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
@@ -60,8 +60,6 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
case i8in64:
case i16in64:
case i32in64:
- case f32in64:
- case i32in128:
for (i = 0; i < size; i += element_size[type])
{
if (memcmp (cmem1 + i,
@@ -72,6 +70,8 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
return 0;
break;
#endif
+ case f32in64:
+ case i32in128:
default:
break;
}
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-02 19:03 [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression Renlin Li
@ 2014-02-03 10:02 ` Renlin Li
2014-02-10 14:03 ` [PING]Re: " Renlin Li
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Renlin Li @ 2014-02-03 10:02 UTC (permalink / raw)
To: gcc-patches; +Cc: Marcus Shawcroft, Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On 02/02/14 19:02, Renlin Li wrote:
> Hi all,
>
> This is a simple patch which resolves
> testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression.
>
> Basically, no special operations are needed for vector type i32in128
> or f32in64 in big-endian mode any more due the aarch64 back-end change.
>
> Okay for trunk?
>
> Kind regards,
> Renlin Li
>
Hi all,
I forgot to attach the ChangeLog. Sorry for this additional annoying email.
Kind regards,
Renlin Li
gcc/testsuite/ChangeLog:
2014-02-03 Renlin Li <Renlin.Li@arm.com>
* gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and
i32in128 cases
outside special big-endian processing block.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: big-endian-3.diff --]
[-- Type: text/x-patch; name=big-endian-3.diff, Size: 802 bytes --]
diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
index ac94625..24431c6 100644
--- a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
+++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
@@ -60,8 +60,6 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
case i8in64:
case i16in64:
case i32in64:
- case f32in64:
- case i32in128:
for (i = 0; i < size; i += element_size[type])
{
if (memcmp (cmem1 + i,
@@ -72,6 +70,8 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
return 0;
break;
#endif
+ case f32in64:
+ case i32in128:
default:
break;
}
^ permalink raw reply [flat|nested] 8+ messages in thread* [PING]Re: [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-03 10:02 ` Renlin Li
@ 2014-02-10 14:03 ` Renlin Li
2014-02-12 15:18 ` Marcus Shawcroft
2014-02-24 9:49 ` [PING][PATCH][AARCH64]Resolves " Renlin Li
2 siblings, 0 replies; 8+ messages in thread
From: Renlin Li @ 2014-02-10 14:03 UTC (permalink / raw)
To: gcc-patches; +Cc: Marcus Shawcroft, Richard Earnshaw
On 03/02/14 10:02, Renlin Li wrote:
> On 02/02/14 19:02, Renlin Li wrote:
>> Hi all,
>>
>> This is a simple patch which resolves
>> testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression.
>>
>> Basically, no special operations are needed for vector type i32in128
>> or f32in64 in big-endian mode any more due the aarch64 back-end change.
>>
>> Okay for trunk?
>>
>> Kind regards,
>> Renlin Li
>>
> Hi all,
>
> I forgot to attach the ChangeLog. Sorry for this additional annoying
> email.
>
> Kind regards,
> Renlin Li
>
> gcc/testsuite/ChangeLog:
>
> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>
> * gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and
> i32in128 cases
> outside special big-endian processing block.
Hi all,
Could somebody help me to review this patch?
Thanks!
Kind regards,
Renlin Li
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-03 10:02 ` Renlin Li
2014-02-10 14:03 ` [PING]Re: " Renlin Li
@ 2014-02-12 15:18 ` Marcus Shawcroft
2014-02-12 16:35 ` Richard Earnshaw
2014-02-24 9:49 ` [PING][PATCH][AARCH64]Resolves " Renlin Li
2 siblings, 1 reply; 8+ messages in thread
From: Marcus Shawcroft @ 2014-02-12 15:18 UTC (permalink / raw)
To: Renlin Li; +Cc: gcc-patches, Marcus Shawcroft, Richard Earnshaw, jakub
On 3 February 2014 10:02, Renlin Li <renlin.li@arm.com> wrote:
> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>
> * gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and
> i32in128 cases
> outside special big-endian processing block.
This is a test case fix. This is ok with me but needs a release manager ack.
/Marcus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-12 15:18 ` Marcus Shawcroft
@ 2014-02-12 16:35 ` Richard Earnshaw
0 siblings, 0 replies; 8+ messages in thread
From: Richard Earnshaw @ 2014-02-12 16:35 UTC (permalink / raw)
To: Marcus Shawcroft, Renlin Li; +Cc: gcc-patches, Marcus Shawcroft, jakub
On 12/02/14 15:18, Marcus Shawcroft wrote:
> On 3 February 2014 10:02, Renlin Li <renlin.li@arm.com> wrote:
>
>> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>>
>> * gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and
>> i32in128 cases
>> outside special big-endian processing block.
>
> This is a test case fix. This is ok with me but needs a release manager ack.
>
> /Marcus
>
s/move/Move/
R.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PING][PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-03 10:02 ` Renlin Li
2014-02-10 14:03 ` [PING]Re: " Renlin Li
2014-02-12 15:18 ` Marcus Shawcroft
@ 2014-02-24 9:49 ` Renlin Li
2014-02-27 12:33 ` Marcus Shawcroft
2 siblings, 1 reply; 8+ messages in thread
From: Renlin Li @ 2014-02-24 9:49 UTC (permalink / raw)
To: gcc-patches; +Cc: Marcus Shawcroft, Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On 03/02/14 10:02, Renlin Li wrote:
> On 02/02/14 19:02, Renlin Li wrote:
>> Hi all,
>>
>> This is a simple patch which resolves
>> testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression.
>>
>> Basically, no special operations are needed for vector type i32in128
>> or f32in64 in big-endian mode any more due the aarch64 back-end change.
>>
>> Okay for trunk?
>>
>> Kind regards,
>> Renlin Li
>>
> Hi all,
>
> I forgot to attach the ChangeLog. Sorry for this additional annoying
> email.
>
> Kind regards,
> Renlin Li
>
> gcc/testsuite/ChangeLog:
>
> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>
> * gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and
> i32in128 cases
> outside special big-endian processing block.
Hi all,
Could anybody help me to review this patch?
Thank you!
Renlin Li
gcc/testsuite/ChangeLog:
2014-02-03 Renlin Li <Renlin.Li@arm.com>
* gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
i32in128 cases
outside special big-endian processing block.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: big-endian-3.diff --]
[-- Type: text/x-patch; name=big-endian-3.diff, Size: 802 bytes --]
diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
index ac94625..24431c6 100644
--- a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
+++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
@@ -60,8 +60,6 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
case i8in64:
case i16in64:
case i32in64:
- case f32in64:
- case i32in128:
for (i = 0; i < size; i += element_size[type])
{
if (memcmp (cmem1 + i,
@@ -72,6 +70,8 @@ validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
return 0;
break;
#endif
+ case f32in64:
+ case i32in128:
default:
break;
}
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PING][PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-24 9:49 ` [PING][PATCH][AARCH64]Resolves " Renlin Li
@ 2014-02-27 12:33 ` Marcus Shawcroft
2014-03-03 12:08 ` Kyrill Tkachov
0 siblings, 1 reply; 8+ messages in thread
From: Marcus Shawcroft @ 2014-02-27 12:33 UTC (permalink / raw)
To: Renlin Li; +Cc: gcc-patches
On 24 February 2014 09:49, Renlin Li <renlin.li@arm.com> wrote:
> gcc/testsuite/ChangeLog:
>
> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>
> * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
> i32in128 cases
> outside special big-endian processing block.
This is is a fix for a broken test case, this is OK.
/Marcus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PING][PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression
2014-02-27 12:33 ` Marcus Shawcroft
@ 2014-03-03 12:08 ` Kyrill Tkachov
0 siblings, 0 replies; 8+ messages in thread
From: Kyrill Tkachov @ 2014-03-03 12:08 UTC (permalink / raw)
To: Marcus Shawcroft; +Cc: Renlin Li, gcc-patches
On 27/02/14 12:33, Marcus Shawcroft wrote:
> On 24 February 2014 09:49, Renlin Li <renlin.li@arm.com> wrote:
>
>> gcc/testsuite/ChangeLog:
>>
>> 2014-02-03 Renlin Li <Renlin.Li@arm.com>
>>
>> * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
>> i32in128 cases
>> outside special big-endian processing block.
>
> This is is a fix for a broken test case, this is OK.
Hi all,
I've committed this as r208275 with ChangeLog entry:
2014-03-03 Renlin Li <Renlin.Li@arm.com>
* gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
i32in128 cases outside special big-endian processing block.
> /Marcus
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-03-03 12:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-02 19:03 [PATCH][AARCH64]Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression Renlin Li
2014-02-03 10:02 ` Renlin Li
2014-02-10 14:03 ` [PING]Re: " Renlin Li
2014-02-12 15:18 ` Marcus Shawcroft
2014-02-12 16:35 ` Richard Earnshaw
2014-02-24 9:49 ` [PING][PATCH][AARCH64]Resolves " Renlin Li
2014-02-27 12:33 ` Marcus Shawcroft
2014-03-03 12:08 ` Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).