[v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

[v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

[Rainer Orth]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Two libstdc++ testcases have been XPASSing on Solaris 9/x86 since
ca. 20130522:

XPASS: 22_locale/num_put/put/char/14220.cc execution test
XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test

Therefore I'd like to remove the xfails since the issue documented there
doesn't seem to trigger anymore.

Bootstrapped without regressions on i386-pc-solaris2.{9, 10, 11}.  Ok
for mainline?

	Rainer


2014-02-05  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* testsuite/22_locale/num_put/put/char/14220.cc: Don't xfail
	execution on i?86-*-solaris2.9, remove comment.
	* testsuite/22_locale/num_put/put/wchar_t/14220.cc: Likewise.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: solx86-v3-14220.patch --]
[-- Type: text/x-patch, Size: 1411 bytes --]

# HG changeset patch
# Parent 0f6d9b9bde5e7eee20486c180ceec28d5043bec7
Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
@@ -19,12 +19,6 @@
 
 // 22.2.2.2.1  num_put members
 
-// On Solaris 9/x86 and 32-bit Solaris 10/x86 before update 10, this test
-// crashes in libc.  Inside libstdc++, we call sprintf like so:
-//   sprintf (buffer, "%.*f", 1000, 1.0)
-// which crashes.
-// { dg-xfail-run-if "" i?86-*-solaris2.9 }
-
 #include <locale>
 #include <sstream>
 #include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
@@ -23,12 +23,6 @@
 #include <sstream>
 #include <testsuite_hooks.h>
 
-// On Solaris 9 and 32-bit Solaris 10/x86 before update 10, this test crashes
-// in libc.  Inside libstdc++, we call sprintf like so:
-//   sprintf (buffer, "%.*f", 1000, 1.0)
-// which crashes.
-// { dg-do run { xfail { i?86-*-solaris2.9 } } } 
-
 // libstdc++/14220
 void test01()
 {

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]


-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: [v3] Don't xfail 22_locale/num_put/put/char/14220.cc etc. on Solaris 9/x86

[Paolo Carlini]

Hi,

On 02/10/2014 04:59 PM, Rainer Orth wrote:
> Two libstdc++ testcases have been XPASSing on Solaris 9/x86 since
> ca. 20130522:
>
> XPASS: 22_locale/num_put/put/char/14220.cc execution test
> XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test
>
> Therefore I'd like to remove the xfails since the issue documented there
> doesn't seem to trigger anymore.
>
> Bootstrapped without regressions on i386-pc-solaris2.{9, 10, 11}.  Ok
> for mainline?
Yes, thanks.

Paolo.