From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1115 invoked by alias); 10 Feb 2014 23:13:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1098 invoked by uid 89); 10 Feb 2014 23:13:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mailrelay5.qsc.de Received: from mailrelay5.qsc.de (HELO mailrelay5.qsc.de) (195.90.0.237) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 10 Feb 2014 23:13:25 +0000 Received: from mx01.qsc.de ([213.148.129.14]) by mailgate5.qsc.de; Tue, 11 Feb 2014 00:13:20 +0100 Received: from tux.net-b.de (port-92-194-199-211.dynamic.qsc.de [92.194.199.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.qsc.de (Postfix) with ESMTPSA id 31BB33CB1F; Tue, 11 Feb 2014 00:13:19 +0100 (CET) Message-ID: <52F95CE2.2080109@net-b.de> Date: Mon, 10 Feb 2014 23:13:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Thomas Schwinge , Ilmir Usmanov CC: Evgeny Gavrin , GarbuzovViacheslav , Dmitri Botcharnikov , gcc-patches@gcc.gnu.org, jakub@redhat.com, fortran@gcc.gnu.org Subject: Re: [PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end References: <52E158EF.9050009@samsung.com> <877g9pqmt2.fsf@schwinge.name> <52E65B24.9070403@samsung.com> <87iot5pgqb.fsf@schwinge.name> <52EB8437.3060602@samsung.com> <52EB84C3.4010407@samsung.com> <52EB8537.4090708@samsung.com> <52EB8596.2010808@samsung.com> <52EB85F7.5020807@samsung.com> <52EB863B.3010501@samsung.com> <52F8127E.6050102@net-b.de> <87lhxjz6x0.fsf@kepler.schwinge.homeip.net> In-Reply-To: <87lhxjz6x0.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-cloud-security-sender:burnus@net-b.de X-cloud-security-recipient:gcc-patches@gcc.gnu.org X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mailgate5 with B18E01490001 X-cloud-security-connect: mx01.qsc.de[213.148.129.14], TLS=, IP=213.148.129.14 X-cloud-security:scantime:.2549 X-SW-Source: 2014-02/txt/msg00637.txt.bz2 Hi! Thomas Schwinge wrote: > Please see > [...] > $ git diff --stat 765faa80eda3bb75aa044ad015e2e5214bf02c6d origin/gomp-4_0-branch | grep -v ChangeLog I am now browsing through the changes. Remarks: 1) I think you also want to set in gcc/fortran/options.c gfc_option.flag_recursive = -1 for OpenACC as it is done for OpenMP. That should be also mentioned in fortran/invoke.texi - without -frecursive, local array variables might be allocated in static memory, which should be incompatible with concurrent invocation. [At least with OpenACC 2.0's $acc routine.] 2) I think OpenACC should also be mentioned at http://gcc.gnu.org/onlinedocs/gfortran/Standards.html and, maybe, at http://gcc.gnu.org/onlinedocs/gfortran/Project-Status.html - however, I suggest not to put the version number there. 3) I think it would be useful to document the constants and the still lacking functions/procedures of openacc.h, openacc_lib.h and the openacc module; maybe you should start with a stub documentation - either by adding it into a separate chapter in libgomp.texi or in an extra document. In any case, there should be some reference to that document from http://gcc.gnu.org/onlinedocs/gfortran/Intrinsic-Modules.html (fortran/intrinsic.texi) >> Can't you? I am not sure whether -fdump-parse-tree is needed; on the >> other hand, it just clutters the *log files. > Yes, I think that should just be in the test case files that actually > need it? I think the parse tree is never really needed - it just dumps the gfortran AST in a somewhat readable form to stdout. Hence, it mainly tests that the compiler doesn't ICE, unless one tries to do pattern matching. (As -fdump-parse-tree is only rarely used, one keeps forgetting about it when extending the AST. Consequently, ICEs aren't that rare.) Tobias