From: Vladimir Makarov <vmakarov@redhat.com>
To: Andrey Belevantsev <abel@ispras.ru>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR 58960
Date: Thu, 13 Feb 2014 16:31:00 -0000 [thread overview]
Message-ID: <52FCF35B.7040109@redhat.com> (raw)
In-Reply-To: <52E9E63D.4070405@ispras.ru>
On 01/30/2014 12:42 AM, Andrey Belevantsev wrote:
> Hello,
>
> As detailed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58960#c6,
> we fail to use the DF liveness info in the register pressure sensitive
> scheduling for the new blocks as we do not properly compute it in this
> case. The patch fixes this by avoiding to use the sched-pressure for
> the new regions, as currently these are only ia64 recovery blocks and
> supposed to be cold. In the case we'd get other cases of the new
> blocks, this may be reconsidered. The other options of computing the
> DF info sketched at the above link do not seem plausible for this stage.
>
> Bootstrapped and tested on ia64, also tested by Andreas Schwab on ia64
> (see PR log). OK for trunk?
>
>
The patch is ok. Andrey, thanks for working on the PR and sorry for the
delay with the approval.
>
> 2013-01-30 Andrey Belevantsev <abel@ispras.ru>
>
> PR rtl-optimization/58960
>
> * haifa-sched.c (alloc_global_sched_pressure_data): New, factored
> out from ...
> (sched_init) ... here.
> (free_global_sched_pressure_data): New, factored out from ...
> (sched_finish): ... here.
> * sched-int.h (free_global_sched_pressure_data): Declare.
> * sched-rgn.c (nr_regions_initial): New static global.
> (haifa_find_rgns): Initialize it.
> (schedule_region): Disable sched-pressure for the newly generated
> regions.
prev parent reply other threads:[~2014-02-13 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 5:42 Andrey Belevantsev
2014-02-07 5:25 ` Andrey Belevantsev
2014-02-13 16:31 ` Vladimir Makarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCF35B.7040109@redhat.com \
--to=vmakarov@redhat.com \
--cc=abel@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).