From: Richard Henderson <rth@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][RFC][libatomic] Override -mcpu option for arm linux ifunc targets
Date: Thu, 13 Feb 2014 18:23:00 -0000 [thread overview]
Message-ID: <52FD0DB6.1090001@redhat.com> (raw)
In-Reply-To: <52EF829A.9010808@arm.com>
On 02/03/2014 03:50 AM, Kyrill Tkachov wrote:
> +# For ARM, the -march option by itself conflicts with any -mcpu option that
> +# we might end up passing to the build, causing an error.
> +# Therefore we override the -mcpu option as well.
> +# This shouldn't affect tuning much because the affected code is mostly
> +# in inline assembly anyway.
> @ARCH_ARM_LINUX_TRUE@@HAVE_IFUNC_TRUE@IFUNC_OPTIONS = -march=armv7-a -DHAVE_KERNEL64
> +@ARCH_ARM_LINUX_TRUE@@HAVE_IFUNC_TRUE@EXTRA_OVERRIDE = -mcpu=cortex-a9
Why would you want to split these across two different variables? It's easier
to just add the -march and -mcpu to the same IFUNC_OPTIONS variable.
Why the choice of cortext-a9, as opposed to any of the other v7-a
possibilities? If we're going to force anything, perhaps generic-armv7-a is
more appropriate?
r~
next prev parent reply other threads:[~2014-02-13 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 11:50 Kyrill Tkachov
2014-02-13 18:10 ` Kyrill Tkachov
2014-02-13 18:23 ` Richard Henderson [this message]
2014-02-17 14:02 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FD0DB6.1090001@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).