From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 7F9793858D28 for ; Fri, 31 Mar 2023 14:13:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F9793858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id iw3so21340317plb.6 for ; Fri, 31 Mar 2023 07:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680271983; x=1682863983; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BiqMgn5vYXv8+B0pjHbsqXygCMRibBrudL+F2ivOih4=; b=BQp8GoR6VN3PMktiIY5Jv3ZxLLv29z/sjwzzhs77UxohP9zTHew9/x/Kpz8eoa2GZ+ n7tuX5APShPSyUIsDNumk8CQ7sAKnXoKuv2m7PxWXcS9YaCukBZDZ59KIIfi9M2agdY6 lnnGjL633sHNI4DNjyML+1SCtB8otygilEjynNa+Q23Oj04g0mx5rZTobGwqUSQ4ShqW n0a6qY4MLhsYuqtEaQFuCHHQ4E5OMEBGk5li2xjFPaBeDTfwmqJ/G60M0C3z64M2eq3K nAIEl+Fn2KZ0HEX3gtGZIUQecb7mlb+WSzAvumlTVx5I0/x8er0RHb9wnJQ4t09sLo40 7w8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680271983; x=1682863983; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BiqMgn5vYXv8+B0pjHbsqXygCMRibBrudL+F2ivOih4=; b=D3f4ihg2JfNUMz+PY4oE5McF3cEO12YgTxJQHwNsxrAnWSwz3XLOUkTsR6xXNdnwh4 ZJRM4O265RgzhXNKKC4Gj8L9mk35vFiniI4UjHMl6o3PJDgm7S8rd2FtZGOdzlYoNxrM Dme/Uw1IoqIc5IgyzgAs63RGXjXzyNbAobvxMq3ki251Q1MaLQdDFptwxflYE1smTKzX bKQLM8WtfREqh59zMizxUdVOYL96CQdlsOi/TGD8VEd8DPaZH3K1zaUagFdYDhtb6eP+ +FdzoKR5Qk3uhcUQjlkUCwMi5gaepFH+wELuWV4RL0onzJUNzuzDd+eZHXfFfo443fTp ce/w== X-Gm-Message-State: AO0yUKWbYKtcDfyeYZj2JH/Og7n2acTawap2EAVZQTgthYaDq+vcWxzR sx5WHFpUHCOcarZEb3ycX73P7+L0vOU= X-Google-Smtp-Source: AK7set8Gofxxg2m8EIOwGNZuw80ljjFdAYGgnvVvYup2op5tZ1cDFSkC99xA1OG7H7ApFqAKFftfZw== X-Received: by 2002:a05:6a20:669f:b0:d7:380b:660 with SMTP id o31-20020a056a20669f00b000d7380b0660mr22580794pzh.3.1680271983540; Fri, 31 Mar 2023 07:13:03 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id t23-20020a62ea17000000b0062d79c41673sm1855154pfh.155.2023.03.31.07.13.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 07:13:03 -0700 (PDT) Message-ID: <52a18588-e22f-6cf2-c3b0-712efbdb3082@gmail.com> Date: Fri, 31 Mar 2023 08:13:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] tree-optimization/107561 - reduce -Wstringop-overflow false positives Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20230329121203.002E43858434@sourceware.org> From: Jeff Law In-Reply-To: <20230329121203.002E43858434@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/29/23 06:11, Richard Biener via Gcc-patches wrote: > The following tells pointer-query to prefer a zero size when we > are querying for the size range for a write into an object we've > determined is of zero size. That avoids diagnostics about really > varying size arguments that just get a meaningful range for example > because they are multiplied by an element size. > > I've adjusted only one call to get_size_range since that's what > I have a testcase for. I think this is the most sensible > "workaround" for some of the false positives we see. > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > OK if it succeeds? > > Thanks, > Richard. > > PR tree-optimization/107561 > * gimple-ssa-warn-access.cc (get_size_range): Add flags > argument and pass it on. > (check_access): When querying for the size range pass > SR_ALLOW_ZERO when the known destination size is zero. > > * g++.dg/pr71488.C: Remove XFAILed bogus diagnostic again. > * g++.dg/warn/Warray-bounds-16.C: Likewise. OK. jeff