public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][OBVIOUS] Remove dead code in IPA ICF.
@ 2019-10-31 16:01 Martin Liška
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Liška @ 2019-10-31 16:01 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi.

This is one another dead code removal.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

I'm going to install the patch.
Thanks,
Martin

gcc/ChangeLog:

2019-10-31  Martin Liska  <mliska@suse.cz>

	* ipa-icf-gimple.c (func_checker::compare_tree_ssa_label): Remove.
	* ipa-icf-gimple.h: Remove declaration from compare_tree_ssa_label
	and compare_memory_operand.
---
 gcc/ipa-icf-gimple.c | 8 --------
 gcc/ipa-icf-gimple.h | 6 ------
 2 files changed, 14 deletions(-)



[-- Attachment #2: 0001-Remove-dead-code-in-IPA-ICF.patch --]
[-- Type: text/x-patch, Size: 1274 bytes --]

diff --git a/gcc/ipa-icf-gimple.c b/gcc/ipa-icf-gimple.c
index 990ee046035..7e4ffc852a8 100644
--- a/gcc/ipa-icf-gimple.c
+++ b/gcc/ipa-icf-gimple.c
@@ -652,14 +652,6 @@ func_checker::compare_gimple_cond (gimple *s1, gimple *s2)
   return compare_operand (t1, t2);
 }
 
-/* Verifies that tree labels T1 and T2 correspond in FUNC1 and FUNC2.  */
-
-bool
-func_checker::compare_tree_ssa_label (tree t1, tree t2)
-{
-  return compare_operand (t1, t2);
-}
-
 /* Verifies for given GIMPLE_LABEL stmts S1 and S2 that
    label statements are semantically equivalent.  */
 
diff --git a/gcc/ipa-icf-gimple.h b/gcc/ipa-icf-gimple.h
index 25dff31394b..8213e4f2f46 100644
--- a/gcc/ipa-icf-gimple.h
+++ b/gcc/ipa-icf-gimple.h
@@ -190,12 +190,6 @@ public:
   /* Verification function for declaration trees T1 and T2.  */
   bool compare_decl (const_tree t1, const_tree t2);
 
-  /* Verifies that tree labels T1 and T2 correspond.  */
-  bool compare_tree_ssa_label (tree t1, tree t2);
-
-  /* Function compare for equality given memory operands T1 and T2.  */
-  bool compare_memory_operand (tree t1, tree t2);
-
   /* Function responsible for comparison of various operands T1 and T2.
      If these components, from functions FUNC1 and FUNC2, are equal, true
      is returned.  */


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH][OBVIOUS] Remove dead code in IPA ICF.
@ 2019-06-04 14:38 Martin Liška
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Liška @ 2019-06-04 14:38 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi.

The patch is about a small clean up, I'm going to install that
as obvious.

Martin

gcc/ChangeLog:

2019-06-04  Martin Liska  <mliska@suse.cz>

	* ipa-icf.c (INCLUDE_LIST): Remove.
	(sem_item_optimizer::execute): Remove call to init_wpa.
	* ipa-icf.h (init_wpa): Remove.
---
 gcc/ipa-icf.c | 4 ----
 gcc/ipa-icf.h | 9 ---------
 2 files changed, 13 deletions(-)



[-- Attachment #2: 0001-Remove-dead-code-in-IPA-ICF.patch --]
[-- Type: text/x-patch, Size: 1501 bytes --]

diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index dbfd3640126..6307407935f 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -52,7 +52,6 @@ along with GCC; see the file COPYING3.  If not see
 */
 
 #include "config.h"
-#define INCLUDE_LIST
 #include "system.h"
 #include "coretypes.h"
 #include "backend.h"
@@ -2543,9 +2542,6 @@ sem_item_optimizer::execute (void)
     fprintf (dump_file, "Dump after hash based groups\n");
   dump_cong_classes ();
 
-  for (unsigned int i = 0; i < m_items.length(); i++)
-    m_items[i]->init_wpa ();
-
   subdivide_classes_by_equality (true);
 
   if (dump_file)
diff --git a/gcc/ipa-icf.h b/gcc/ipa-icf.h
index 6b81eb38b2a..2bf0f156ef6 100644
--- a/gcc/ipa-icf.h
+++ b/gcc/ipa-icf.h
@@ -190,9 +190,6 @@ public:
   /* Dump function for debugging purpose.  */
   DEBUG_FUNCTION void dump (void);
 
-  /* Initialize semantic item by info reachable during LTO WPA phase.  */
-  virtual void init_wpa (void) = 0;
-
   /* Semantic item initialization function.  */
   virtual void init (void) = 0;
 
@@ -325,10 +322,6 @@ public:
 
   ~sem_function ();
 
-  inline virtual void init_wpa (void)
-  {
-  }
-
   virtual void init (void);
   virtual bool equals_wpa (sem_item *item,
 			   hash_map <symtab_node *, sem_item *> &ignored_nodes);
@@ -432,8 +425,6 @@ public:
 
   sem_variable (varpool_node *_node, bitmap_obstack *stack);
 
-  inline virtual void init_wpa (void) {}
-
   /* Semantic variable initialization function.  */
   inline virtual void init (void)
   {


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-31 15:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 16:01 [PATCH][OBVIOUS] Remove dead code in IPA ICF Martin Liška
  -- strict thread matches above, loose matches on Subject: below --
2019-06-04 14:38 Martin Liška

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).