From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id C73DE385841F for ; Sat, 1 Jul 2023 11:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C73DE385841F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fbc59de0e2so21647295e9.3 for ; Sat, 01 Jul 2023 04:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688211912; x=1690803912; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lwOsT4xN78PhZ4Gd/OlQNT6QFF7fOWoUf05WRKCDtU0=; b=lvWs4TBUJTDkfBuie0VK7hXrUAzjBK7CVXmFR/5eSxyQyK1pM277u1Rta1Ulvmtp5J KZV/HswcGLpxxtn0cMGgH//sXn4Z7ZHLLaPlWjrFPRjZHA3+O+qhTuvWfKG3A+KlUACa W8ipHFStCT9CFlGB/mUjtYcAGCScC6f2tWfAgqLMkfeVOUqYEyY6xkzYqwHPAxuEYYoy onW8WS9EHp9Xq4OnA8bgMVmZkBE9oiwGDI3oDEckKIsJg68LPia8sg8kBEUMShGqxvNF 2ShppUOdNJk6XJkqIVAhWTGFIzZnpBXrqKqC7zxK5aio1j+5dvsGR+I5FgvqPFQOO9y7 ofEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688211912; x=1690803912; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lwOsT4xN78PhZ4Gd/OlQNT6QFF7fOWoUf05WRKCDtU0=; b=KC5fCwkPW9JsBk4iH8gyMydC6anE8GMMrpMYRodbEHa6q3oPjfGbyi1gZ+zyWyv7vn khPRK5Qkd8H3Q17nRFi3qUzaYUV7ffSSpSH1gcHAqFixyWHTK8dk+6TeePXuFGNSid2z ACw6yaGh7pA/Ta0tfgzgA4uo3tlEgOGRLT7kMItB7c2lwR34BnA3WGdB38wAEGFKDYvH VMdApsMxTlPVhAzfcO08NYb1MqnKg/J903CZisaXx760b1TXmLGTdFgM8jn/yK0MsGgw 7X6wh/ryi/5d4pZ8SrSy0iVrRQTwUeSWOirhbPLls58HGFHhyh3jX3r4b2F71cX6eA/P gePQ== X-Gm-Message-State: ABy/qLZqpbcmGKcblmSS7FOKysFAv/tRo+3S6d8txrg6ulOSK/dvtlYO fEY4r3FCLEtIytKo08sR1rI= X-Google-Smtp-Source: APBJJlGOl6gSzE/o19AoKultfjw1EkQQ/6vLXpjIEQ0nLAPOyZAhC6ZmnivVa6Pj6dXcXFJsZt692A== X-Received: by 2002:adf:f690:0:b0:314:2ea7:af4a with SMTP id v16-20020adff690000000b003142ea7af4amr673726wrp.13.1688211912236; Sat, 01 Jul 2023 04:45:12 -0700 (PDT) Received: from [192.168.1.24] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm10897482wmk.48.2023.07.01.04.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 04:45:11 -0700 (PDT) Message-ID: <52e12ab2-4dd7-93ae-9c83-9577015a3b30@gmail.com> Date: Sat, 1 Jul 2023 13:45:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com, "kito.cheng" , "kito.cheng" , palmer , palmer Subject: Re: [PATCH] RISC-V: Support vfwmul.vv combine lowering To: Jeff Law , =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches References: <20230628041512.188243-1-juzhe.zhong@rivai.ai> <70EE22A0D10CD0D8+2023062906005450585022@rivai.ai> <62be1be8-280f-2989-6a31-32c87dcbadcd@gmail.com> <11e4d710-cc52-748a-7ab2-ff489c2a02aa@gmail.com> Content-Language: en-US From: Robin Dapp In-Reply-To: <11e4d710-cc52-748a-7ab2-ff489c2a02aa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > There has to be some kind of mismatch between the patch or testcase > or what we're looking at to judge success. Yeah I think the initially posted example was misleading because it contained an already working example. > While I really don't see the need to have the bridge pattern, I'm > still willing to believe that I've missed something, which is why I > wanted to dive into it myself. For example, we have heuristics to > avoid trying too many 4->n combine patterns and we might be tripping > over that or who knows what. > > So my suggestion is that if both of you are getting the desired code, > then Robin handle the review side of the two patches that introduce > the helper patterns. I went over both patches again and given the context they seem reasonable to me. I'd propose go with both of them for now and - in the meanwhile - I'm going to brush up on my combine knowledge some time in the next weeks and get back to this then, hopefully with a better explanation than my last one. Regards Robin