From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63507 invoked by alias); 6 Mar 2015 09:42:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63494 invoked by uid 89); 6 Mar 2015 09:42:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Mar 2015 09:42:00 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id E9C9F281748F; Fri, 6 Mar 2015 10:41:57 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8UA3ANtQDmNq; Fri, 6 Mar 2015 10:41:57 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id C697B2817487; Fri, 6 Mar 2015 10:41:57 +0100 (CET) From: Eric Botcazou To: Kyrill Tkachov Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][simplify-rtx] PR 65235: Calculate element size correctly when simplifying (vec_select (vec_concat (const_int) (...)) [...]) Date: Fri, 06 Mar 2015 09:42:00 -0000 Message-ID: <5304338.pAnzusuvRk@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <54F6D239.2010902@arm.com> References: <54F6D239.2010902@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2015-03/txt/msg00339.txt.bz2 > The patch fixes that by calculating the size of the first element by > taking the size of the outer mode and subtracting the size of the second > element. > > I've added an assert to make sure that the second element is not also a > const_int, as a vec_concat of const_ints doesn't make sense as far as I can > see. I'm not sure about the assert, can't we just punt in this case? > Bootstrapped and tested on aarch64-none-linux-gnu, > arm-none-linux-gnueabihf, x86_64-linux-gnu. > This bug appears on trunk, 4.9 and 4.8, so it's not a regression on the > release branches but it is a wrong-code bug. I think that the fix would be acceptable for GCC 5 without the assert. -- Eric Botcazou