public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <burnus@net-b.de>
To: Ilmir Usmanov <i.usmanov@samsung.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
	 Evgeny Gavrin <e.gavrin@samsung.com>,
	GarbuzovViacheslav <v.garbuzov@samsung.com>,
	 Dmitri Botcharnikov <dmitry.b@samsung.com>,
	gcc-patches@gcc.gnu.org, jakub@redhat.com, fortran@gcc.gnu.org
Subject: Re: [PATCH 1/4] [GOMP4] [Fortran] OpenACC 1.0+ support in fortran front-end
Date: Wed, 12 Mar 2014 18:27:00 -0000	[thread overview]
Message-ID: <5320A5BB.9000604@net-b.de> (raw)
In-Reply-To: <5319A335.2090202@samsung.com>

On March 7, 2014 11:45, Ilmir Usmanov wrote:
> OpenACC 1.0 support to fortran FE -- core.

Looks good to me. As Thomas is also fine with the patch set [1], the 
patch can now go into the branch :-)

Previously and still approved are Part 3 and 4 [2] of the series. I will 
separately reply to Part 2.

Tobias

[1] http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00472.html
[2] http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00399.html , 
http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00400.html

> gcc/fortran/
>     * dump-parse-tree.c
>     (show_omp_node): Dump also OpenACC executable statements.
>     (show_code_node): Call it.
>     (show_namespace): Dump !$ACC DECLARE directive.
>     * gfortran.h
>     (ST_OACC_PARALLEL_LOOP, ST_OACC_END_PARALLEL_LOOP, ST_OACC_PARALLEL,
>     ST_OACC_END_PARALLEL, ST_OACC_KERNELS, ST_OACC_END_KERNELS,
>     ST_OACC_DATA, ST_OACC_END_DATA, ST_OACC_HOST_DATA,
>     ST_OACC_END_HOST_DATA, ST_OACC_LOOP, ST_OACC_DECLARE, ST_OACC_UPDATE,
>     ST_OACC_WAIT, ST_OACC_CACHE, ST_OACC_KERNELS_LOOP,
>     ST_OACC_END_KERNELS_LOOP, ST_OACC_ENTER_DATA,
>     ST_OACC_EXIT_DATA, ST_OACC_END_LOOP): New statements.
>     (gfc_expr_list): New structure to hold list of expressions.
>     (OMP_LIST_COPY, OMP_LIST_DATA_CLAUSE_FIRST,
>     OMP_LIST_OACC_COPYIN, OMP_LIST_COPYOUT, OMP_LIST_CREATE, 
> OMP_LIST_DELETE,
>     OMP_LIST_PRESENT, OMP_LIST_PRESENT_OR_COPY,
>     OMP_LIST_PRESENT_OR_COPYIN, OMP_LIST_PRESENT_OR_COPYOUT,
>     OMP_LIST_PRESENT_OR_CREATE, OMP_LIST_DEVICEPTR,
>     OMP_LIST_DATA_CLAUSE_LAST, OMP_LIST_USE_DEVICE,
>     OMP_LIST_DEVICE_RESIDENT, OMP_LIST_HOST, OMP_LIST_DEVICE,
>     OMP_LIST_CACHE): New types of list, allowed in clauses.
>     (gfc_omp_clauses): Add OpenACC clauses.
>     (gfc_namespace): Add OpenACC declare directive clauses.
>     (EXEC_OACC_KERNELS_LOOP, EXEC_OACC_PARALLEL_LOOP, EXEC_OACC_PARALLEL,
>     EXEC_OACC_KERNELS, EXEC_OACC_DATA, EXEC_OACC_HOST_DATA, 
> EXEC_OACC_LOOP,
>     EXEC_OACC_UPDATE, EXEC_OACC_WAIT, EXEC_OACC_CACHE, 
> EXEC_OACC_ENTER_DATA,
>     EXEC_OACC_EXIT_DATA): New executable statements.
>     (gfc_free_expr_list): New function declaration.
>     (gfc_resolve_oacc_directive): Likewise.
>     (gfc_resolve_oacc_parallel_loop_blocks): Likewise.
>     (gfc_resolve_oacc_blocks): Likewise.
>     * match.c (match_exit_cycle): Add support of OpenACC regions and 
> loops.
>     * match.h (gfc_match_oacc_cache): New function declaration.
>     (gfc_match_oacc_wait, gfc_match_oacc_update): Likewise.
>     (gfc_match_oacc_declare, gfc_match_oacc_loop): Likewise.
>     (gfc_match_oacc_host_data, gfc_match_oacc_data): Likewise.
>     (gfc_match_oacc_kernels, gfc_match_oacc_kernels_loop): Likewise.
>     (gfc_match_oacc_parallel, gfc_match_oacc_parallel_loop): Likewise.
>     (gfc_match_oacc_enter_data, gfc_match_oacc_exit_data): Likewise.
>     * parse.c (decode_oacc_directive): New function.
>     (verify_token_free, verify_token_fixed): New helper functions.
>     (next_free, next_fixed): Decode !$ACC sentinel.
>     (case_executable): Add ST_OACC_UPDATE, ST_OACC_WAIT, ST_OACC_CACHE,
>     ST_OACC_ENTER_DATA and ST_OACC_EXIT_DATA directives.
>     (case_exec_markers): Add ST_OACC_PARALLEL_LOOP, ST_OACC_PARALLEL,
>     ST_OACC_KERNELS, ST_OACC_DATA, ST_OACC_HOST_DATA, ST_OACC_LOOP and
>     ST_OACC_KERNELS_LOOP directives.
>     (push_state): Initialize OpenACC declare clauses.
>     (gfc_ascii_statement): Dump names of OpenACC directives.
>     (verify_st_order): Verify OpenACC declare directive as declarative.
>     (parse_spec): Push clauses to state stack when declare directive is
>     parsed.
>     (parse_oacc_structured_block, parse_oacc_loop): New functions.
>     (parse_executable): Call them.
>     (parse_progunit): Move declare clauses from state stack to namespace.
>     * parse.h (gfc_state_data): Add declare directive's clauses.
>     * resolve.c (gfc_resolve_blocks): Resolve OpenACC directives.
>     (resolve_code): Likewise.
>     * scanner.c (openacc_flag, openacc_locus): New static variables.
>     (skip_oacc_attribute, skip_omp_attribute): New helper functions.
>     (skip_free_comments, skip_fixed_comments): Don't skip !$ACC sentinel.
>     (gfc_next_char_literal): Support OpenACC directives.
>     * st.c (gfc_free_statement): Free also OpenACC directives.

  parent reply	other threads:[~2014-03-12 18:21 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 18:01 [PATCH] [GOMP4] " Ilmir Usmanov
2014-01-23 18:03 ` [PATCH 1/6] " Ilmir Usmanov
2014-01-23 18:03   ` [PATCH 2/6] " Ilmir Usmanov
2014-01-23 18:04     ` [PATCH 3/6] " Ilmir Usmanov
2014-01-23 18:05       ` [PATCH 4/6] " Ilmir Usmanov
2014-01-23 18:05         ` [PATCH 5/6] " Ilmir Usmanov
2014-01-23 18:06           ` [PATCH 6/6] " Ilmir Usmanov
2014-01-23 18:09             ` [PATCH 7/6] " Ilmir Usmanov
2014-01-24 19:33         ` [PATCH 4/6] " Thomas Schwinge
2014-11-05 16:29           ` [gomp4] OpenACC cache directive for C Thomas Schwinge
2014-11-05 16:36             ` [gomp4] OpenACC cache directive maintenance (was: [PATCH 4/6] [GOMP4] OpenACC 1.0+ support in fortran front-end) Thomas Schwinge
2014-11-05 16:45               ` [gomp4] OpenACC cache directive maintenance Thomas Schwinge
2015-10-27 15:26                 ` [PR fortran/63865] OpenACC cache directive: match Fortran support with C/C++ (was: [gomp4] OpenACC cache directive maintenance) Thomas Schwinge
2015-10-27 15:30                   ` Jakub Jelinek
2015-10-27 17:03                     ` [PR fortran/63865] OpenACC cache directive: match Fortran support with C/C++ Thomas Schwinge
2014-11-05 16:49             ` [gomp4] Testing of C/C++ OpenACC cache directive (was: OpenACC cache directive for C) Thomas Schwinge
2016-06-02 11:47             ` [PR c/71381] C/C++ OpenACC cache directive rejects valid syntax (was: [gomp4] OpenACC cache directive for C.) Thomas Schwinge
2016-06-08 13:29               ` [PING] [PR c/71381] C/C++ OpenACC cache directive rejects valid syntax Thomas Schwinge
2016-06-08 14:07                 ` Jakub Jelinek
2016-06-10 10:32                   ` Thomas Schwinge
2016-06-10 13:14                     ` Thomas Schwinge
2016-06-10 20:40                       ` Gerald Pfeifer
2014-01-24 20:47     ` [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end Thomas Schwinge
2014-01-24 20:31   ` [PATCH 1/6] " Thomas Schwinge
2014-01-27 19:37     ` Tobias Burnus
2014-01-24 18:04 ` [PATCH] " Thomas Schwinge
2014-01-27 13:12   ` Ilmir Usmanov
2014-01-27 15:49     ` Thomas Schwinge
2014-01-27 16:35       ` Ilmir Usmanov
2014-01-31 11:14       ` Ilmir Usmanov
2014-01-31 11:16         ` [PATCH 1/6] " Ilmir Usmanov
2014-01-31 11:17           ` [PATCH 2/6] " Ilmir Usmanov
2014-01-31 11:18             ` [PATCH 3/6] " Ilmir Usmanov
2014-01-31 11:22               ` [PATCH 4/6] " Ilmir Usmanov
2014-01-31 11:34                 ` [PATCH 5/6] " Ilmir Usmanov
2014-01-31 11:45                   ` [PATCH 6/6] " Ilmir Usmanov
2014-02-09 23:43                   ` [PATCH 5/6] " Tobias Burnus
2014-02-10  8:52                     ` Thomas Schwinge
2014-02-10  9:34                       ` Ilmir Usmanov
2014-02-10 23:13                       ` Tobias Burnus
2014-02-10  9:45                     ` Ilmir Usmanov
2014-02-10 10:52                       ` Thomas Schwinge
2014-02-11 16:51                 ` [PATCH 4/6] " Thomas Schwinge
2014-02-13 13:15                   ` Ilmir Usmanov
2014-02-13 14:57                     ` Thomas Schwinge
2014-02-14  5:45                       ` Ilmir Usmanov
2014-02-21 19:29                   ` [GOMP4] gimple_code_is_oacc -> is_gimple_omp_oacc_specifically (was: [PATCH 4/6] [GOMP4] OpenACC 1.0+ support in fortran front-end) Thomas Schwinge
2014-02-09 23:24               ` [PATCH 3/6] [GOMP4] OpenACC 1.0+ support in fortran front-end Tobias Burnus
2014-02-09 23:10             ` [PATCH 2/6] " Tobias Burnus
2014-02-10  9:10               ` Thomas Schwinge
2014-02-19 16:43               ` Ilmir Usmanov
2014-01-31 12:00           ` [PATCH 1/6] " Jakub Jelinek
2014-01-31 12:33             ` Ilmir Usmanov
2014-02-03 15:21               ` [PING] " Ilmir Usmanov
2014-02-09 22:22           ` Tobias Burnus
2014-02-19 15:34             ` Ilmir Usmanov
2014-02-19 23:52               ` Tobias Burnus
2014-02-20  8:19                 ` Ilmir Usmanov
2014-03-04  7:56                   ` [PATCH 1/4] [GOMP4] [Fortran] " Ilmir Usmanov
2014-03-04  7:57                     ` Ilmir Usmanov
2014-03-04  7:57                       ` [PATCH 2/4] " Ilmir Usmanov
2014-03-04  7:58                         ` [PATCH 3/4] " Ilmir Usmanov
2014-03-04  7:59                           ` [PATCH 4/4] " Ilmir Usmanov
2014-03-04 22:56                             ` Tobias Burnus
2014-03-04 22:52                           ` [PATCH 3/4] " Tobias Burnus
2014-03-04 17:20                       ` [PATCH 1/4] " Tobias Burnus
2014-03-07 10:44                         ` Ilmir Usmanov
2014-03-07 10:45                           ` Ilmir Usmanov
2014-03-07 10:46                             ` [PATCH 2/4] " Ilmir Usmanov
2014-03-07 10:46                               ` [PATCH 3/4] " Ilmir Usmanov
2014-03-07 10:47                                 ` [PATCH 4/4] " Ilmir Usmanov
2014-03-08 17:55                                   ` Tobias Burnus
2014-03-20 10:53                                   ` Thomas Schwinge
2014-03-20 12:48                                     ` Ilmir Usmanov
2014-03-20 14:43                                     ` Jakub Jelinek
2014-03-08 17:19                                 ` [PATCH 3/4] " Tobias Burnus
2014-03-08 19:55                               ` [PATCH 2/4] " Tobias Burnus
2014-03-11 12:04                                 ` Ilmir Usmanov
2014-03-12 18:46                                   ` Tobias Burnus
2014-03-12 18:27                             ` Tobias Burnus [this message]
2014-03-13  9:41                               ` [PATCH 1/4] " Ilmir Usmanov
2014-03-13 11:43                                 ` Thomas Schwinge
2014-03-13 13:24                                   ` Ilmir Usmanov
2014-03-13 14:13                                     ` Ilmir Usmanov
2014-03-16 19:46                                       ` Tobias Burnus
2014-03-16 20:44                                         ` Thomas Schwinge
2014-04-05 10:40                                         ` Thomas Schwinge
2014-03-10 15:44                           ` Thomas Schwinge
2014-03-04 17:42                       ` Tobias Burnus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5320A5BB.9000604@net-b.de \
    --to=burnus@net-b.de \
    --cc=dmitry.b@samsung.com \
    --cc=e.gavrin@samsung.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=i.usmanov@samsung.com \
    --cc=jakub@redhat.com \
    --cc=thomas@codesourcery.com \
    --cc=v.garbuzov@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).