From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id A799838930F5 for ; Sun, 19 Nov 2023 18:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A799838930F5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A799838930F5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418942; cv=none; b=WhNHjGp5F7+uTQCuHoya1PGNjjVfmv85BODTSHgFIropwYqr53GzFKBUsPOqVS3Ak3RmHQHjnCiDBiTdS14z3l/RSXh3xyhQk/6lf2mHJvvP9YgFFn3MWPMuMWeoZB/uIw/45+da83bu5Utmk8iA0Gke8voeMjThYK/csasqnnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418942; c=relaxed/simple; bh=0CCy8+fHqAcWdfD2FL4qFOuZpGSlOSnJ9YKq36AInVc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=O25hEmXcUbMP77CiW6S9bfYizbSAgK9tl945zRxl7aEnnNM25WbsUmi8NCRNslPT2wVel47jYL22i6MZXIa4CnDTZD/hU/hK2zQKTsbv/Md2dAk5uIPjVJBho1MoZBEwhyobfwIjrAHGE/+fSl9dnzoexbFPpyUTh3EZE6jzKIs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1efabc436e4so2308994fac.1 for ; Sun, 19 Nov 2023 10:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700418941; x=1701023741; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qYBmxNlHJ9Y7RMLKGS1gwegfIoL2erQuEXHNmq1VEIw=; b=juKOImj9Diz94Qki710XzsgtvZTkcKy1A8TacegcqfJDuhYUjBgbNfmQRRpO37V+ih UVDkrXQDGY2pLdaMu0HmSvOUizTjoZCcxAlTG6SGU+Ir5ldfmgjgUbZLPKWTLUat4BgJ Y2Lni+crWRvZOdeiWskHNq6e1m5RmuF+oEeBOcF65X6iBB+UXnnOyddU4PTO1XFSkRkJ 6mmjEjGkG1lL8hz0wGswyCG5esTXYA2eEU8kdlc7zxRYUEkAPWiKsfQ0RniVLDF7f6zB pg4tr1eD4VXzQr/+1o5Emjoh9+/7qnF7lEkDkid+kykuH/51Q9LyvkkEDLU8Mwfictc3 b7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700418941; x=1701023741; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qYBmxNlHJ9Y7RMLKGS1gwegfIoL2erQuEXHNmq1VEIw=; b=PxaCApV/ncwvXMaGYOq/quAlMnPNje8ZFDOIXgud6jEBsXbKHgT7x4XDIQar6rMNdD PMQ1EKbZc8DKMowizhFRTJEiBSGbK0PiBJbHRgEkBbILgXd+dzflueYH/Nye9QAvVYAa 3qKI/X0EQ3bo3TI9rx+buG9lttfAnb3VBdvkk4r6UHr2QaFVnVFcmC/eST5mHYoCuoXE llgU2toCSSz5jXqZgwbhWgHKZ76w8iymAb33ZlLws+zLLRTcdtb34zOKBtEaZ7e5ThgJ x7RjN+5ij0uh2CqpoRW+cHKcyJN29RFODjZNlVpFSFrQbyLXSuKwgNZp0Q4tijkOUvOh mxVQ== X-Gm-Message-State: AOJu0YyhdV+cbdxcbTOpmx0oIYwvmkfdSd7tK/LxahunSoIdxArUN+O4 ouJxx+iNmKnBNHTiulqbhKs= X-Google-Smtp-Source: AGHT+IH8PvCuQrEb4Z73GNBoGamRvUyPpUjQN1Mj7vFdSBvcpxsqJSHkMRJTo9Kx0rDMaRGkAcbGpg== X-Received: by 2002:a05:6870:35c8:b0:1c8:c27f:7d9b with SMTP id c8-20020a05687035c800b001c8c27f7d9bmr6426993oak.27.1700418941059; Sun, 19 Nov 2023 10:35:41 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id tp12-20020a0568718b8c00b001d4c5e4c2c5sm1047295oab.25.2023.11.19.10.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 10:35:40 -0800 (PST) Message-ID: <53256f9f-d26a-4fe6-836a-4d4c8dd67ec4@gmail.com> Date: Sun, 19 Nov 2023 11:35:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 22/44] RISC-V: Fold all the cond-move variants together Content-Language: en-US To: "Maciej W. Rozycki" , gcc-patches@gcc.gnu.org Cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/23 22:40, Maciej W. Rozycki wrote: > Code in `riscv_expand_conditional_move' for Ventana and Zicond targets > seems like bolted on as an afterthought rather than properly merged so > as to handle all the cases together. You could characterize it that way. It was mostly a desire to not muck up any of the thead or sfb code which I know next to nothing about. I think with the improvements in the testsuite from your series it's a lot more feasible to unify the implementations and be sure we haven't broken something along the way. > > Fold the existing code pieces together then (observing that for short > forward branch targets no integer comparisons need to be canonicalized), > letting T-Head targets produce branchless sequences for all the integer > comparisons rather than for equality ones only, and preparing for the > handling of floating-point comparisons here across all conditional-move > targets. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Unify > conditional-move handling across all the relevant targets. OK jeff