Re: [RFC] [PATCH v3 0/8] [i386] Use out-of-line stubs for ms_abi pro/epilogues

[Daniel Santos <daniel.santos@pobox.com>]

On 02/10/2017 06:20 PM, JonY wrote:
> On 02/10/2017 05:23 PM, Daniel Santos wrote:
>> On 02/10/2017 05:34 AM, JonY wrote:
>>> Hi,
>>> mingw-w64 itself does not use any ms_abi/sysv_abi marked functions
>>> internally, so it should be unaffected. I don't think Cygwin uses any
>>> either, but I need to double check.
>> Of course, ms_abi is gcc's default on Windows so it would be sysv_abi
>> functions.  I'm *guessing* that just about everything with Cygwin is
>> built for Windows, but it would also make sense if (in some odd case) a
>> binary built with sysv_abi is used by something and that library or
>> program makes the ABI transition when using said hypothetical library.
>> Even in these cases, I would not anticipate a problem, although any use
>> of SEH would inhibit the optimization.  Of course, I haven't *tested*
>> this, so I'm only speaking from what I know. :)
>>
> Cygwin has internal functions marked ms_abi but none with sysv_abi, so
> it will be unaffected by this change. Most 64bit mingw-w64 toolchains
> are built with SEH for exception handling though, but since it is
> disabled, it shouldn't break anything.
>
> If its not too much to ask, please do a gcc build targeting 32bit/64bit
> mingw-w64 and Cygwin, it'll make solid evidence that the changes do not
> break the compiler.
>
> Thanks.

Will do. I'll even run a query afterwards and see if anything in Cygwin 
actually makes cross-ABI functions just for the sake of our collective 
curiosity. It's always nice to know.  It is important that I make sure 
we don't break anything in Cygwin, being that I've mostly been thinking 
about Wine.

Daniel