From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7218 invoked by alias); 24 Apr 2014 21:27:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7203 invoked by uid 89); 24 Apr 2014 21:27:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 21:27:45 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OLRhSt026302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Apr 2014 17:27:43 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-78.phx2.redhat.com [10.3.113.78]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3OLRgUr023430; Thu, 24 Apr 2014 17:27:42 -0400 Message-ID: <535981CE.9070104@redhat.com> Date: Thu, 24 Apr 2014 21:33:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Marek Polacek , Prathamesh Kulkarni CC: gcc-patches@gcc.gnu.org, "Joseph S. Myers" Subject: Re: [C PATCH] remove goto in c_parser_sizeof_expression References: <20140222181444.GJ10901@redhat.com> <20140222194827.GK10901@redhat.com> <20140224175853.GB16545@redhat.com> <20140224192823.GC16545@redhat.com> In-Reply-To: <20140224192823.GC16545@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg01601.txt.bz2 On 02/24/14 12:28, Marek Polacek wrote: > On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: >> Replaced tab by 4 spaces before error_at. >> * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. > > Looks good now, but I can't approve it. Thanks, Applied to the trunk. Thanks and sorry for the delays. jeff