From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4886 invoked by alias); 27 Apr 2014 18:47:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4863 invoked by uid 89); 27 Apr 2014 18:47:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx02.qsc.de Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 27 Apr 2014 18:47:24 +0000 Received: from tux.net-b.de (port-92-194-43-249.dynamic.qsc.de [92.194.43.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx02.qsc.de (Postfix) with ESMTPSA id 64B7B276E2; Sun, 27 Apr 2014 20:47:21 +0200 (CEST) Message-ID: <535D50B8.3070801@net-b.de> Date: Sun, 27 Apr 2014 18:56:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Mikael Morin , jimmie.davis@l-3com.com, gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: patch fortran, pr 59746, internal compiler error : segmentation fault References: ,<531CA574.2050900@sfr.fr> ,<531CD1A3.6070303@sfr.fr> <5322208C.1010002@sfr.fr> In-Reply-To: <5322208C.1010002@sfr.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2014-04/txt/msg01796.txt.bz2 Given that we are now in stage 1: Mikael and Bud, what's the status of this patch? http://gcc.gnu.org/ml/fortran/2014-03/msg00098.html Tobias On January 13, 2014 22:18, Mikael Morin wrote: > Hello, > > Le 10/03/2014 03:15, jimmie.davis@l-3com.com a écrit : >> Index: gcc/gcc/fortran/symbol.c >> =================================================================== >> --- gcc/gcc/fortran/symbol.c (revision 208437) >> +++ gcc/gcc/fortran/symbol.c (working copy) >> @@ -3069,56 +3069,56 @@ >> >> FOR_EACH_VEC_ELT (latest_undo_chgset->syms, i, p) >> { >> - if (p->gfc_new) >> + /* Symbol was new. Or was old and just put in common. */ > Now the comment needs updating as "just put in common" also applies to > the "new" case. Or you can also remove it ("just put in common" is > somewhat redundant with the other comment anyway). > >> + if ( p->attr.in_common && p->common_block && p->common_block->head >> + && (p->gfc_new || !p->old_symbol->attr.in_common)) >> { >> - /* Symbol was new. */ >> - if (p->attr.in_common && p->common_block && p->common_block->head) >> - { >> - /* If the symbol was added to any common block, it >> - needs to be removed to stop the resolver looking >> - for a (possibly) dead symbol. */ >> + /* If the symbol was added to any common block, it >> + needs to be removed to stop the resolver looking >> + for a (possibly) dead symbol. */ > "needs" should be aligned with "If" like it was before; same for "for". > > Now we are in pretty good shape. > > The ICE happens with invalid code after reporting an error, correct? > Then I agree, this should rather wait for stage 1. > > Thanks > Mikael >