From: John Marino <gnugcc@marino.st>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Ian Lance Taylor <iant@google.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
binutils@sourceware.org, gdb-patches@sourceware.org
Subject: [PING] Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
Date: Tue, 29 Apr 2014 15:39:00 -0000 [thread overview]
Message-ID: <535FC71E.8070406@marino.st> (raw)
In-Reply-To: <53541A34.7050908@marino.st>
Hi folks,
Does anyone have any issues with this set of patches to add support for
the DragonFly targets? It's a blocker for other patches of mine that
have a more general benefit, but this (relatively simple) one has to go
in first.
Thanks,
John
On 4/20/2014 21:04, John Marino wrote:
> On 4/20/2014 14:51, Jonathan Wakely wrote:
>> On 19 April 2014 20:39, John Marino wrote:
>>> Hello GCC developers,
>>>
>>> For the last few years, I have been maintaining a large set of patches
>>> that add support for the DragonFly BSD target and also complete Ada
>>> frontend support on all four major BSDs among other things. Before I
>>> can submit patches for Ada or testsuite cases, DragonFly must be a
>>> recognized, working target. The patches attached here will provide
>>> out-of-the-box support for the C, C++, Objective-C and Fortran frontends.
>>
>> Thanks for the patch - I only have a few general, minor comments. As
>> noted at http://gcc.gnu.org/lists.html C++ library patches should go
>> to the libstdc++ list as well as gcc-patches, so I've CC'd that list
>> (original mail and patch are at
>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01128.html)
>>
>> Patches should not include generated files such as configure, as the
>> diffs don't always apply cleanly and the changes are implied by the
>> patches to files such as acinclude.m4 and configure.ac. The
>> regenerated versions should of course be committed, and the ChangeLog
>> should mention they are regenerated, as you've done.
>
> Thanks for your advice, Jonathan.
> I've updated the patch to remove the two "configure" file patches. I
> also removed an errant "-rpath" from the dragonfly.h specs that crept in
> from FreeBSD ports. I've attached the updated patch to this email.
>
>>
>> The changelog text should be correctly capitalised and sentences ended
>> with a period (e.g. "New target." and "New." not "New target" and
>> "new"). The individual ChangeLog entries at
>> http://leaf.dragonflybsd.org/~marino/gcc-df-target/changelog_entries/
>> would generally be used as the commit message, grouped and prefixed by
>> the name of the sub-directory:
>>
>
>
> I have updated the six entry files at
> http://leaf.dragonflybsd.org/~marino/gcc-df-target/changelog_entries/ to
> conform to this style. I updated the proposed commit message
> accordingly:
> http://leaf.dragonflybsd.org/~marino/gcc-df-target/proposed_commit-msg.txt
>
>
>>
>> The libstdc++ changes are OK for trunk if the rest gets approved.
>
> Thanks!
> I see from the critique of another submitted patch that also touches
> liberty that I'm supposed to cross-post to gdb and binutils, so I've
> cc'd them as well.
>
> Regards,
> John
>
next prev parent reply other threads:[~2014-04-29 15:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 19:41 John Marino
2014-04-20 19:05 ` Jonathan Wakely
2014-04-21 4:41 ` John Marino
2014-04-29 15:39 ` John Marino [this message]
2014-04-29 17:25 ` [PING] " Ian Lance Taylor
2014-04-29 18:50 ` John Marino
2014-04-30 0:07 ` Ian Lance Taylor
2014-05-01 23:03 ` Joseph S. Myers
2014-05-01 23:46 ` John Marino
2014-05-02 17:49 ` Joseph S. Myers
2014-05-02 18:17 ` John Marino
2014-05-02 20:15 ` Joseph S. Myers
2014-05-02 20:20 ` John Marino
2014-05-03 7:12 ` John Marino
2014-05-08 13:15 ` Jonathan Wakely
2014-05-08 13:32 ` Jeff Law
2014-05-08 13:36 ` John Marino
2014-05-09 5:27 ` Jeff Law
2014-05-09 7:15 ` John Marino
2014-05-12 16:59 ` Jeff Law
2014-05-12 17:10 ` John Marino
2014-05-12 17:14 ` Jeff Law
2014-05-13 14:10 ` Jonathan Wakely
2014-05-21 11:43 ` Jonathan Wakely
2015-04-09 20:12 ` [doc] Add John Marino to doc/contrib.texi (was: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly) Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535FC71E.8070406@marino.st \
--to=gnugcc@marino.st \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=iant@google.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).