From: John Marino <gnugcc@marino.st>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Jonathan Wakely <jwakely.gcc@gmail.com>,
Gerald Pfeifer <gerald@pfeifer.com>,
manu@gcc.gnu.org,
"Eric Botcazou (gnu.org)" <ebotcazou@gcc.gnu.org>
Subject: Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
Date: Thu, 01 May 2014 23:46:00 -0000 [thread overview]
Message-ID: <5362DC9B.8090709@marino.st> (raw)
In-Reply-To: <Pine.LNX.4.64.1405012259450.16441@digraph.polyomino.org.uk>
On 5/2/2014 01:03, Joseph S. Myers wrote:
> The include of <sys/types.h> from <stddef.h> seems risky, given that
> that's a POSIX header that typically defines various types ISO C does not
> permit to be defined in <stddef.h> (ISO C does not have any general *_t
> namespace reservation, unlike POSIX).
>
> Have you verified that if you include <stddef.h> with -std=c90 / -std=c99
> / -std=c11, the resulting definitions (compiler and preprocessor) are all
> ones permitted by the relevant C standard version to be provided by
> <stddef.h>?
You bring up some interesting points. I haven't specific tested
anything like that, but DragonFly has been using this modification for
years - since gcc 4.6 at least. It is even in the primary base compiler:
http://gitweb.dragonflybsd.org/dragonfly.git/blob_plain/HEAD:/contrib/gcc-4.7/gcc/ginclude/stddef.h
So given the track record (building itself, building base, building
21,000 software ports) over a couple of years I think any issues this
could have caused would have been seen and identified by now.
>
> (I don't know what the FreeBSD <sys/_types.h> defines, but it at least
> seems possible from the name that it is only defining things in the
> implementation namespace, with the public <sys/types.h> being what then
> includes <sys/_types.h> and does "typedef __foo_t foo_t;" or similar to
> provide the public POSIX types that aren't in ISO C.)
Here are the headers in question:
http://grok.dragonflybsd.org/xref/freebsd/sys/sys/_types.h
http://grok.dragonflybsd.org/xref/dragonfly/sys/sys/types.h
Thanks,
John
next prev parent reply other threads:[~2014-05-01 23:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 19:41 John Marino
2014-04-20 19:05 ` Jonathan Wakely
2014-04-21 4:41 ` John Marino
2014-04-29 15:39 ` [PING] " John Marino
2014-04-29 17:25 ` Ian Lance Taylor
2014-04-29 18:50 ` John Marino
2014-04-30 0:07 ` Ian Lance Taylor
2014-05-01 23:03 ` Joseph S. Myers
2014-05-01 23:46 ` John Marino [this message]
2014-05-02 17:49 ` Joseph S. Myers
2014-05-02 18:17 ` John Marino
2014-05-02 20:15 ` Joseph S. Myers
2014-05-02 20:20 ` John Marino
2014-05-03 7:12 ` John Marino
2014-05-08 13:15 ` Jonathan Wakely
2014-05-08 13:32 ` Jeff Law
2014-05-08 13:36 ` John Marino
2014-05-09 5:27 ` Jeff Law
2014-05-09 7:15 ` John Marino
2014-05-12 16:59 ` Jeff Law
2014-05-12 17:10 ` John Marino
2014-05-12 17:14 ` Jeff Law
2014-05-13 14:10 ` Jonathan Wakely
2014-05-21 11:43 ` Jonathan Wakely
2015-04-09 20:12 ` [doc] Add John Marino to doc/contrib.texi (was: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly) Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5362DC9B.8090709@marino.st \
--to=gnugcc@marino.st \
--cc=ebotcazou@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=joseph@codesourcery.com \
--cc=jwakely.gcc@gmail.com \
--cc=manu@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).