From: Florian Weimer <fweimer@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
shenhan@google.com, Jeff Law <law@redhat.com>
Subject: Re: [PATCH Ping v2] Extend -fstack-protector-strong to cover calls with return slot
Date: Mon, 05 May 2014 11:58:00 -0000 [thread overview]
Message-ID: <53677CC8.7020802@redhat.com> (raw)
In-Reply-To: <52EF5BD4.9000701@redhat.com>
On 02/03/2014 10:05 AM, Florian Weimer wrote:
> On 01/17/2014 11:26 AM, Florian Weimer wrote:
>> On 01/08/2014 03:57 PM, Florian Weimer wrote:
>>
>>> What about the attached version? It still does not exactly match your
>>> original suggestion because gimple_call_lhs (stmt) can be NULL_TREE if
>>> the result is ignored and this case needs instrumentation, as you
>>> explained, so I use the function return type in the aggregate_value_p
>>> check.
>>>
>>> Testing is still under way, but looks good so far. I'm bootstrapping
>>> with BOOT_CFLAGS="-O2 -g -fstack-protector-strong" with Ada enabled, for
>>> additional coverage.
>>
>> Testing passed without new regressions. Is this okay for trunk?
>
> Ping? Thanks.
Now that 4.9 is released, I'd like to propose again this fix for inclusion:
<http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00374.html>
--
Florian Weimer / Red Hat Product Security Team
next prev parent reply other threads:[~2014-05-05 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 13:15 Florian Weimer
2014-01-03 18:57 ` Jakub Jelinek
2014-01-03 21:43 ` Florian Weimer
2014-01-07 12:51 ` Florian Weimer
2014-01-07 13:07 ` Jakub Jelinek
2014-01-07 13:27 ` Florian Weimer
2014-01-07 13:37 ` Jakub Jelinek
2014-01-08 14:57 ` Florian Weimer
2014-01-17 10:26 ` Florian Weimer
2014-02-03 9:05 ` [PATCH Ping] " Florian Weimer
2014-05-05 11:58 ` Florian Weimer [this message]
2014-05-09 6:26 ` [PATCH Ping v2] " Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53677CC8.7020802@redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=shenhan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).