From: Jeff Law <law@redhat.com>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>,
"'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)"
<gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <rdsandiford@googlemail.com>,
Rich Fuhler <Rich.Fuhler@imgtec.com>
Subject: Re: [PATCH] copyprop_hardreg_forward needs to check HARD_REGNO_CALL_PART_CLOBBERED
Date: Fri, 09 May 2014 06:19:00 -0000 [thread overview]
Message-ID: <536C7387.8040804@redhat.com> (raw)
In-Reply-To: <6D39441BF12EF246A7ABCE6654B02353523563@LEMAIL01.le.imgtec.org>
On 05/07/14 09:52, Matthew Fortune wrote:
> The MIPS O32 FPXX ABI exposes a bug in regcprop where call part
> clobbered information is not checked when calculating clobbered
> registers. This is only one of many places that
> regs_invalidated_by_call is used without also checking
> HARD_REGNO_CALL_PART_CLOBBERED. This patch ensures that a part
> clobbered register is treated as if fully clobbered.
>
> Other places where this same issue occurs are not so easily
> fixed as they do not always have mode information available
> when calculating clobbered registers. A solution to the larger
> problem will be significantly more involved.
>
> Exposed in a testcase as part of:
> http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00401.html
>
> Regards,
> Matthew
>
> 2014-05-07 Matthew Fortune <matthew.fortune@imgtec.com>
>
> gcc/
> * regcprop.c (copyprop_hardreg_forward_1): Account for
> HARD_REGNO_CALL_PART_CLOBBERED.
OK.
Jeff
prev parent reply other threads:[~2014-05-09 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 15:52 Matthew Fortune
2014-05-09 6:19 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536C7387.8040804@redhat.com \
--to=law@redhat.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=Rich.Fuhler@imgtec.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).