From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8149 invoked by alias); 9 May 2014 06:19:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8132 invoked by uid 89); 9 May 2014 06:19:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 May 2014 06:19:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s496JrEq025550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 May 2014 02:19:53 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-56.phx2.redhat.com [10.3.113.56]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s496Jp32026655; Fri, 9 May 2014 02:19:52 -0400 Message-ID: <536C7387.8040804@redhat.com> Date: Fri, 09 May 2014 06:19:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Matthew Fortune , "'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)" CC: Richard Sandiford , Rich Fuhler Subject: Re: [PATCH] copyprop_hardreg_forward needs to check HARD_REGNO_CALL_PART_CLOBBERED References: <6D39441BF12EF246A7ABCE6654B02353523563@LEMAIL01.le.imgtec.org> In-Reply-To: <6D39441BF12EF246A7ABCE6654B02353523563@LEMAIL01.le.imgtec.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00555.txt.bz2 On 05/07/14 09:52, Matthew Fortune wrote: > The MIPS O32 FPXX ABI exposes a bug in regcprop where call part > clobbered information is not checked when calculating clobbered > registers. This is only one of many places that > regs_invalidated_by_call is used without also checking > HARD_REGNO_CALL_PART_CLOBBERED. This patch ensures that a part > clobbered register is treated as if fully clobbered. > > Other places where this same issue occurs are not so easily > fixed as they do not always have mode information available > when calculating clobbered registers. A solution to the larger > problem will be significantly more involved. > > Exposed in a testcase as part of: > http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00401.html > > Regards, > Matthew > > 2014-05-07 Matthew Fortune > > gcc/ > * regcprop.c (copyprop_hardreg_forward_1): Account for > HARD_REGNO_CALL_PART_CLOBBERED. OK. Jeff