From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12141 invoked by alias); 9 May 2014 06:26:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12130 invoked by uid 89); 9 May 2014 06:26:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 May 2014 06:26:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s496QAgP006823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 May 2014 02:26:10 -0400 Received: from stumpy.slc.redhat.com (ovpn-113-56.phx2.redhat.com [10.3.113.56]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s496Q9wW002922; Fri, 9 May 2014 02:26:10 -0400 Message-ID: <536C7501.3030300@redhat.com> Date: Fri, 09 May 2014 06:26:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Florian Weimer , Jakub Jelinek CC: GCC Patches , shenhan@google.com Subject: Re: [PATCH Ping v2] Extend -fstack-protector-strong to cover calls with return slot References: <52C6B807.1070203@redhat.com> <20140103185715.GO892@tucnak.redhat.com> <52C72F05.2060901@redhat.com> <52CBF834.3040004@redhat.com> <20140107130748.GP892@tucnak.redhat.com> <52CC00A8.7070203@redhat.com> <20140107133723.GR892@tucnak.redhat.com> <52CD6755.5060003@redhat.com> <52D9055F.9030403@redhat.com> <52EF5BD4.9000701@redhat.com> <53677CC8.7020802@redhat.com> In-Reply-To: <53677CC8.7020802@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00556.txt.bz2 On 05/05/14 05:58, Florian Weimer wrote: > On 02/03/2014 10:05 AM, Florian Weimer wrote: >> On 01/17/2014 11:26 AM, Florian Weimer wrote: >>> On 01/08/2014 03:57 PM, Florian Weimer wrote: >>> >>>> What about the attached version? It still does not exactly match your >>>> original suggestion because gimple_call_lhs (stmt) can be NULL_TREE if >>>> the result is ignored and this case needs instrumentation, as you >>>> explained, so I use the function return type in the aggregate_value_p >>>> check. >>>> >>>> Testing is still under way, but looks good so far. I'm bootstrapping >>>> with BOOT_CFLAGS="-O2 -g -fstack-protector-strong" with Ada enabled, >>>> for >>>> additional coverage. >>> >>> Testing passed without new regressions. Is this okay for trunk? >> >> Ping? Thanks. > > Now that 4.9 is released, I'd like to propose again this fix for inclusion: > > OK for the trunk. jeff