Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

[Dimitris Papavasiliou <dpapavas@gmail.com>]

Ping!

On 05/05/2014 10:35 AM, Dimitris Papavasiliou wrote:
> Ping!
>
> On 04/28/2014 01:35 PM, Dimitris Papavasiliou wrote:
>> On 04/25/2014 07:50 PM, Mike Stump wrote:
>>> On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou<dpapavas@gmail.com>
>>> wrote:
>>>
>>>> --Wreturn-type -Wsequence-point -Wshadow @gol
>>>> +-Wreturn-type -Wsequence-point -Wshadow -Wshadow-ivar @gol
>>>
>>> This has to be -Wno-shadow-ivar, we document the non-defaultÂ…
>>>
>>>> +@item -Wshadow-ivar @r{(Objective-C only)}
>>>
>>> Likewise.
>>>
>>>> + /* Check wheter the local variable hides the instance variable. */
>>>
>>> spelling, whether...
>>
>> Fixed these.
>>
>>>> + a = private; /* { dg-warning "hides instance variable" "" { xfail
>>>> *-*-* } } */
>>>> + a = protected; /* { dg-warning "hides instance variable" "" { xfail
>>>> *-*-* } } */
>>>> + a = public; /* { dg-warning "hides instance variable" "" { xfail
>>>> *-*-* } } */
>>>
>>> No, we donÂ’t expect failures. We makes the compiler do what we wants
>>> or it gets the hose again. Then, we expect it to be perfect. If you
>>> wonÂ’t want warning, and non are produces, then just remove the /* Â…
>>> */, or write /* no warning */.
>>
>> I've fixed these as per your request. For the record though, this form
>> of test seems to be fairly common in the test suites as this output
>> indicates:
>>
>> dimitris@debian:~/sandbox/gcc-build$ find ../gcc-source/gcc/testsuite/
>> -name "*.c" -o -name "*.C" -o -name "*.m" | xargs grep "xfail \*-\*-\*"
>> | wc -l
>> 354
>>
>> Many of these seem to be in error or warning messages which are expected
>> not to show up. In any case if the messages do show up they'll trigger
>> the excessive messages test so I suppose that's enough.
>>
>>> Also, synth up the ChnageLogsÂ… :-), they are trivial enough.
>>
>> Done.
>>
>>> And, just pop them all into one patch (cd ..; svn diff), 3 is 3x the
>>> work for me.
>>
>> Attached.
>>
>>> Once we resolve the 3 warning tests above, this will be ok.
>>
>> Actually, there were a few more { xfail *-*-* } in the other test cases.
>> I've removed these as well.
>>
>> Dimitris
>>
>