From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25165 invoked by alias); 12 May 2014 07:49:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25154 invoked by uid 89); 12 May 2014 07:49:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ee0-f44.google.com Received: from mail-ee0-f44.google.com (HELO mail-ee0-f44.google.com) (74.125.83.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 12 May 2014 07:49:24 +0000 Received: by mail-ee0-f44.google.com with SMTP id c41so4292174eek.17 for ; Mon, 12 May 2014 00:49:21 -0700 (PDT) X-Received: by 10.14.180.8 with SMTP id i8mr30048123eem.67.1399880961244; Mon, 12 May 2014 00:49:21 -0700 (PDT) Received: from [192.168.1.11] (ppp-94-65-209-48.home.otenet.gr. [94.65.209.48]) by mx.google.com with ESMTPSA id r1sm30957573eew.30.2014.05.12.00.49.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 12 May 2014 00:49:20 -0700 (PDT) Message-ID: <53707DD2.2090004@gmail.com> Date: Mon, 12 May 2014 07:49:00 -0000 From: Dimitris Papavasiliou User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Mike Stump CC: "gcc-patches@gcc.gnu.org Patches" Subject: Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope References: <52F35508.4080205@gmail.com> <5486E33D-B8F6-473F-8F33-6A7DEECB45A8@comcast.net> <5359999C.7090607@gmail.com> <757BB622-2CA8-4C9A-BCA9-AAD1FDF8F14F@comcast.net> <535A8EA8.5040706@gmail.com> <80E7465A-6FE8-475D-873E-FF2F2C8EC2ED@comcast.net> <535E2EF9.3070500@gmail.com> <53673F30.80402@gmail.com> In-Reply-To: <53673F30.80402@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00732.txt.bz2 Ping! On 05/05/2014 10:35 AM, Dimitris Papavasiliou wrote: > Ping! > > On 04/28/2014 01:35 PM, Dimitris Papavasiliou wrote: >> On 04/25/2014 07:50 PM, Mike Stump wrote: >>> On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou >>> wrote: >>> >>>> --Wreturn-type -Wsequence-point -Wshadow @gol >>>> +-Wreturn-type -Wsequence-point -Wshadow -Wshadow-ivar @gol >>> >>> This has to be -Wno-shadow-ivar, we document the non-default… >>> >>>> +@item -Wshadow-ivar @r{(Objective-C only)} >>> >>> Likewise. >>> >>>> + /* Check wheter the local variable hides the instance variable. */ >>> >>> spelling, whether... >> >> Fixed these. >> >>>> + a = private; /* { dg-warning "hides instance variable" "" { xfail >>>> *-*-* } } */ >>>> + a = protected; /* { dg-warning "hides instance variable" "" { xfail >>>> *-*-* } } */ >>>> + a = public; /* { dg-warning "hides instance variable" "" { xfail >>>> *-*-* } } */ >>> >>> No, we don’t expect failures. We makes the compiler do what we wants >>> or it gets the hose again. Then, we expect it to be perfect. If you >>> won’t want warning, and non are produces, then just remove the /* … >>> */, or write /* no warning */. >> >> I've fixed these as per your request. For the record though, this form >> of test seems to be fairly common in the test suites as this output >> indicates: >> >> dimitris@debian:~/sandbox/gcc-build$ find ../gcc-source/gcc/testsuite/ >> -name "*.c" -o -name "*.C" -o -name "*.m" | xargs grep "xfail \*-\*-\*" >> | wc -l >> 354 >> >> Many of these seem to be in error or warning messages which are expected >> not to show up. In any case if the messages do show up they'll trigger >> the excessive messages test so I suppose that's enough. >> >>> Also, synth up the ChnageLogs… :-), they are trivial enough. >> >> Done. >> >>> And, just pop them all into one patch (cd ..; svn diff), 3 is 3x the >>> work for me. >> >> Attached. >> >>> Once we resolve the 3 warning tests above, this will be ok. >> >> Actually, there were a few more { xfail *-*-* } in the other test cases. >> I've removed these as well. >> >> Dimitris >> >